#7874 Add support for group attributes #7875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offtherailz
commented
Feb 23, 2022
|
@offtherailz @taba90 moving to next major. We will include this on MS master as soon as also GeoStore master will be updated accordingly. |
4 tasks
|
This is the PR to merge on GeoStore to make this PR working |
offtherailz
commented
Dec 14, 2022
offtherailz
commented
Dec 14, 2022
offtherailz
commented
Dec 14, 2022
offtherailz
commented
Dec 15, 2022
offtherailz
commented
Dec 15, 2022
MV88
requested changes
Dec 15, 2022
| })); | ||
| }); | ||
| useEffect(() => { | ||
| loadOptions().then(setOptions); |
There was a problem hiding this comment.
what happens if an error occurs in here?
do we have to handle error somehow?
There was a problem hiding this comment.
no options are show. I think it is acceptable (I don't think react-select provides sufficient api for error show).
Co-authored-by: Matteo V. <matteo.velludini@geosolutionsgroup.com>
MV88
approved these changes
Dec 15, 2022
|
@ElenaGallo, could you please test this on DEV ? Thank you as admin user you will be able to see attributes tab, with a notes attribute. You can test by creating a new group saving its attributes and so on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR provides support for group attribute management. By default the tab is hidden (we can decide to add one notes attribute, just to test the functionality).
In draft because it requires :
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
No group attribute support
What is the new behavior?
closes #7874
closes https://github.com/geosolutions-it/npa-cgg/issues/279
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
For testing:
as admin user, when open "account management" and browse groups, you will be able to see a new tab for groups, where to see/edit the user group attributes. By default I added a "notes" attribute for testing.
You can try to create a group, then edit the group, change the "notes" attribute, try to save and so on.