Skip to content

Fix GISDocument not applying projection argument #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Fix GISDocument not applying projection argument #732

wants to merge 18 commits into from

Conversation

elifsu-simula
Copy link
Collaborator

@elifsu-simula elifsu-simula commented Jun 4, 2025 •
edited
Loading

Description

Resolves #688

Due to the new view missing center and zoom, extent was not being calculated, which caused projection to not being applied. Now we set the new view to this._Map before calling _moveToPosition function. We also set the projection in state to update the projection in status bar.

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--732.org.readthedocs.build/en/732/
💡 JupyterLite preview: https://jupytergis--732.org.readthedocs.build/en/732/lite

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025

Binder 👈 Launch a Binder on branch elifsu-simula/jupytergis/fix-projection-in-widget

@elifsu-simula elifsu-simula added the bug Something isn't working label Jun 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025 •
edited
Loading

Integration tests report: appsharing.space

@mfisher87
Copy link
Member

Nice! I do see that the projection is correctly set in the .jgis file, but the status bar is still showing EPSG:3857

image

mfisher87 and others added 15 commits June 12, 2025 14:05
@mfisher87 @arjxn-py
@YaoTingYao @jmarokhovsky @martinRenou @elifsu-simula
Support importing from path alias @ (geojupyter#728)
0276d03 
* Attempt support for path alias "@"

Co-authored-by: Arjun Verma <arjxn.py@gmail.com>
Co-authored-by: Yao-Ting Yao <94820616+YaoTingYao@users.noreply.github.com>
Co-authored-by: Jon Marokhovsky <jmarokhovsky@users.noreply.github.com>

* Support absolute paths with typescript-transform-paths and ts-patch

Requires using `tspc` as compiler instead of `tsc`. Would be better to
switch to the "use NX" approach of typescript-transform-paths, but I
wasn't able to get that to work.

Co-authored-by: martinRenou <martin.renou@gmail.com>

* Revert "Attempt support for path alias "@""

This reverts commit 5f9255b.

* Remove baseUrl from tsconfig -- it is equivalent to the default value

* Lint 🔔

* Update all imports which include `../`

I skipped updating sibling imports (`import ... from './foo'`) because
often sibling imports reflect that the code is tightly coupled. We can
always replace those with absolute imports if we feel it's necessary as
we continue along.

* Lint 🔔

---------

Co-authored-by: Arjun Verma <arjxn.py@gmail.com>
Co-authored-by: Yao-Ting Yao <94820616+YaoTingYao@users.noreply.github.com>
Co-authored-by: Jon Marokhovsky <jmarokhovsky@users.noreply.github.com>
Co-authored-by: martinRenou <martin.renou@gmail.com>
@mfisher87 @elifsu-simula
Consistently sort and group all TS imports (geojupyter#730)
7302f8b
@mfisher87 @elifsu-simula
Update prettier config to always use trailing commas (geojupyter#731)
e4d2567
@Gauss-Taylor-Euler @elifsu-simula
Solving geojupyter#461 (geojupyter#736)
d88bdef
@Gauss-Taylor-Euler @elifsu-simula
Processing: Centroids of a vector layer (geojupyter#740)
79292a3
@martinRenou @elifsu-simula
Fix LayoutRestorer entries (geojupyter#743)
11d74e5
@MMesch @elifsu-simula
new feature request template (geojupyter#746)
c9491e8
@Gauss-Taylor-Euler @elifsu-simula
Processing: Bounding boxes of a vector layer(geojupyter#734) (geojup…
e2d915f 
…yter#744)

* Processing: Bounding boxes of a vector layer(geojupyter#734)

* Change Bounding Boxes and Centroids labels to correspond to qgis naming convention
@gjmooney @elifsu-simula
Enhance proxy (geojupyter#748)
14f9530 
* Enhance proxy

* Test fix

* Use os environ for exempt domains
@gjmooney @elifsu-simula
Create shared components (geojupyter#749)
9ca8281 
* Create some shared components

* Add tabs; Add CSS

* Button CSS

* Use newer button

* Add components for date picker

* Add pagination component

* Iterate on paginator

* Tiny tweaks

* Use the correct package.json

* lint

* Woops

* Use jupyter css vars

* Add sr-only class

* Lint

* Clean up
@arjxn-py @mfisher87 @elifsu-simula
Refactor vector symbology: Configure radius and color separately (geo…
11dfaa9 
…jupyter#714)

Co-authored-by: Matt Fisher <3608264+mfisher87@users.noreply.github.com>
Co-authored-by: Matt Fisher <mfisher87@gmail.com>
@elifsu-simula
Wait for options to load before generating scene
6cd3182
@elifsu-simula
Make sure projection is applied to map with layers
00c17c2
@elifsu-simula
Lint
37b1fa9
@elifsu-simula
Yarn lock
4bcaa79
@elifsu-simula
Copy link
Collaborator Author

elifsu-simula commented Jun 12, 2025 •
edited
Loading

The issue was that the status bar was being updated in moveend, that's why it was not immediately updated. It is now updated when we update the projection in updateOptions function. It works fine almost always for JGIS files. However for QGS and QGZ files it does not apply the projection about half of the time. Unfortunately I could not find out why this happens. I realized that when we are building the widget for the second time (when we provide a filename), sometimes the arguments of the GISDocument is lost, that is why the default projection is applied. I am happy to work more on this issue, but I will be off for the next 3 weeks. If this is something that needs to be solved immediately, then if someone else can take a look it would be great. Otherwise I will continue with my work when I'm back.

@elifsu-simula elifsu-simula marked this pull request as draft June 12, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GISDocument's projection argument is not respected
7 participants
@elifsu-simula @mfisher87 @Gauss-Taylor-Euler @martinRenou @MMesch @gjmooney @arjxn-py