Skip to content

new feature request template #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

MMesch
Copy link
Contributor

@MMesch MMesch commented Jun 9, 2025

Description

Adds new feature request template.

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--746.org.readthedocs.build/en/746/
💡 JupyterLite preview: https://jupytergis--746.org.readthedocs.build/en/746/lite

Copy link
Contributor

github-actions bot commented Jun 9, 2025

Binder 👈 Launch a Binder on branch MMesch/jupytergis/mmesch%2Ffeature-request-template

Copy link
Contributor

github-actions bot commented Jun 9, 2025

Integration tests report: appsharing.space

Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MMesch! Looks really good.

Linter fails, you would want to run jlpm run lint and then push the changes :)

@MMesch MMesch force-pushed the mmesch/feature-request-template branch from 3c519b2 to 20c4a74 Compare June 9, 2025 20:19
@MMesch
Copy link
Contributor Author

MMesch commented Jun 9, 2025

@arjxn-py , I changed the solution to optional and ran the linter.

Copy link
Member

@mfisher87 mfisher87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @MMesch 😍

@mfisher87 mfisher87 merged commit 0e416de into geojupyter:main Jun 9, 2025
14 checks passed
elifsu-simula pushed a commit to elifsu-simula/jupytergis that referenced this pull request Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants