Create and edit vector layers #692
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
HaudinFlorence
force-pushed
the
create_and_edit_vector_layers
branch
2 times, most recently
from
340db85 to
916653b
Compare
|
Yess! This feature is very in-demand :) 👏 |
HaudinFlorence
force-pushed
the
create_and_edit_vector_layers
branch
from
916653b to
d28d98c
Compare
Thanks for having added the link to the related issue @mfisher87 . The first version will probably be a simple one not including all the features mentioned in the issue. |
martinRenou
reviewed
May 13, 2025
|
Integration tests report: appsharing.space |
HaudinFlorence
force-pushed
the
create_and_edit_vector_layers
branch
6 times, most recently
from
e0b14ec to
da4628c
Compare
|
If you don't mind, I turn this PR in draft for now (it helps me knowing if the PR requires a review) |
HaudinFlorence
force-pushed
the
create_and_edit_vector_layers
branch
4 times, most recently
from
29935fa to
0a1d7c7
Compare
martinRenou
requested changes
May 20, 2025
HaudinFlorence
force-pushed
the
create_and_edit_vector_layers
branch
6 times, most recently
from
20d5375 to
7c0dbda
Compare
…y to not have a path provided and to enable the creation of an empty layer with geoJSON source with embedded data.
…plus toolbar button and using the already existing dialog and form. Modify the logics to enable situations where no path is provided in the dialog. Remove the command addNewDrawVectorLayer and the toolbar button. Remove method createEmptyVectorLayerWithGeoJSONSource from JupyterGISModel class and IJupyterGISModel interface. Update _handleDrawGeometryTypeChange method from the MainView class. Add a condition if GeoJSONSourcePropertiesForm for the case where there is no path.
…remove the condition for no path case that was wrongly in the onFormSubmit method of the parent class PathBasedSourceProperties. Update _handleDrawGeometryTypeChange in MainView class.
…JSONSourcePropertiesForm.
for more information, see https://pre-commit.ci
Co-authored-by: martinRenou <martin.renou@gmail.com>
In leftPanel,use notifyCommandChanged for all commands. Fix bug regarding the overlay display when a draw vector layer is removed. Enable the toggleDrawFeature command only when the layer is a draw vector layer one.
HaudinFlorence
force-pushed
the
create_and_edit_vector_layers
branch
3 times, most recently
from
193108d to
0fc0f9f
Compare
Add Select interaction. Set activity of the different interactions properly.
HaudinFlorence
force-pushed
the
create_and_edit_vector_layers
branch
from
0fc0f9f to
ce17370
Compare
for more information, see https://pre-commit.ci
martinRenou
reviewed
Jun 17, 2025
Co-authored-by: martinRenou <martin.renou@gmail.com>
HaudinFlorence
force-pushed
the
create_and_edit_vector_layers
branch
3 times, most recently
from
b47a58c to
03dfcda
Compare
…ent calling editVectorLayer on irrelevant layers.
HaudinFlorence
force-pushed
the
create_and_edit_vector_layers
branch
from
03dfcda to
65e400e
Compare
|
Thanks! @mfisher87 would you have time to have a look? How about we tackle the |
That sounds good to me! |
Started reviewing today but ran out of time, too many meetings and stuff :X I'm off the rest of the week but will definitely have time to look closer Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some of #395 ; resolves #775
Create and edit vector layers
Screencast.From.2025-06-09.11-49-15.mp4
+button of the toolbar, then selectingadd new vector layerandnew geoJSON Layerleading to the opening of the dedicated Dialog.Changes have been done to enable situations where no path is provided
Point,LineStringandPolygon📚 Documentation preview: https://jupytergis--692.org.readthedocs.build/en/692/
💡 JupyterLite preview: https://jupytergis--692.org.readthedocs.build/en/692/lite