Fixed sequence-point-related undefined behaviour (vesoft-inc#1062)

geekyin · Oct 15, 2019 · 43094c3 · 43094c3
1 parent 1eb4ded
commit 43094c3
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/meta/processors/admin/AdminClient.cpp b/src/meta/processors/admin/AdminClient.cpp
@@ -304,7 +304,7 @@ void AdminClient::getResponse(
                     LOG(INFO) << "Rpc failure to " << hosts[index]
                               << ", retry " << retry
                               << ", limit " << retryLimit;
-                    index = ++index % hosts.size();
+                    index = (index + 1) % hosts.size();
                     getResponse(std::move(hosts),
                                 index,
                                 std::move(req),
@@ -337,7 +337,7 @@ void AdminClient::getResponse(
                             LOG(INFO) << "The leader is in election"
                                       << ", retry " << retry
                                       << ", limit " << retryLimit;
-                            index = ++index % hosts.size();
+                            index = (index + 1) % hosts.size();
                             getResponse(std::move(hosts),
                                     index,
                                     std::move(req),
@@ -385,7 +385,7 @@ void AdminClient::getResponse(
                                   << " from " << hosts[index]
                                   << ", retry " << retry
                                   << ", limit " << retryLimit;
-                        index = ++index % hosts.size();
+                        index = (index + 1) % hosts.size();
                         getResponse(std::move(hosts),
                                     index,
                                     std::move(req),