Validate random and QR input bounds#2480
Open
paulolokaux-sudo wants to merge 1 commit into
Open
Conversation
Contributor
|
Please could you add an AI Disclosure statement in the PR description. The template added when manually creating a PR reads: AI disclosure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds explicit input validation for three operation edge cases so invalid numeric arguments return clear CyberChef operation messages instead of unhandled
RangeErrors or silent empty output.Fixes #2447.
Fixes #2448.
Fixes #2449.
Changes
Generate QR Codemodule size and margin before callingqr-image.Pseudo-Random Number Generatorbyte count before allocating/generating bytes.Pseudo-Random Integer Generatorcount before generating output.Verification
npx grunt configTestsnpm run lintnpm testnpm startand Playwright MCP against the issue deep linksnpm run buildNote:
npm run buildcompleted successfully. During build, Webpack Bundle Analyzer printed existing ENOENT parsing warnings for worker bundle names while generating its report, then webpack compiled successfully and Grunt finished withDone.