Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port ign image to ros2 #59

Merged
merged 3 commits into from
Dec 11, 2019
Merged

Port ign image to ros2 #59

merged 3 commits into from
Dec 11, 2019

Conversation

JShep1
Copy link

@JShep1 JShep1 commented Dec 11, 2019

No description provided.

@JShep1 JShep1 requested a review from chapulina December 11, 2019 18:45
@chapulina chapulina added the ROS 2 ROS 2 label Dec 11, 2019
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor

Thanks, @JShep1 , works great! I just had to add ament_export_include_directories(include) for it to compile on my workspace.

I also pushed a few smaller changes on 56a2ac9:

  • Added AMENT_IGNORE to the test directory so the linters don't look at it just yet
  • Fixed all linter issues. Those can be checked running colcon test --packages-select-regex ros_ign_image and then looking at log/latest_test/ros_ign_image/streams.log, for example.
  • Kept the test cmake code commented out so we don't lose track of it.

I'll merge this into #58 and then we can get it all into dashing at once 😄

@chapulina chapulina merged commit 69a6e95 into port_dashing_demos Dec 11, 2019
@chapulina chapulina deleted the port_ign_image branch December 11, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ROS 2 ROS 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants