Closed kinematic chain#987
Open
yaswanth1701 wants to merge 11 commits into
Open
Conversation
scpeters
reviewed
May 21, 2026
| #============================================================================ | ||
| # Find gz-cmake | ||
| #============================================================================ | ||
| find_package(gz-cmake REQUIRED) |
Member
There was a problem hiding this comment.
these look like changes from jetty (gz-physics9). can you rebase the relevant commits onto main?
Member
There was a problem hiding this comment.
here is a comparison of an earlier state of your branch against gz-physics9 before it was merged with main:
Member
There was a problem hiding this comment.
if you could rebranch from there and then add any missing commits, then you could try squashing it all and rebasing onto main?
Contributor
Author
There was a problem hiding this comment.
Sorry for the trouble. The issue is resolved now.
Signed-off-by: yaswanth1701 <gonnayaswanth17@gmail.com>
Signed-off-by: yaswanth1701 <gonnayaswanth17@gmail.com>
yaswanth1701
force-pushed
the
closed-kinematic_chain
branch
2 times, most recently
from
0827b85 to
4ee9c1d
Compare
Signed-off-by: yaswanth1701 <gonnayaswanth17@gmail.com>
Signed-off-by: yaswanth1701 <gonnayaswanth17@gmail.com>
Signed-off-by: yaswanth1701 <gonnayaswanth17@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes #25
Summary
This feature supports closed kinematic chains for dartsim.
Test it
gz-physics/test/common_test/worlds/Video
Screencast.from.05-22-2026.01.03.48.AM.webm
Screencast.from.05-22-2026.01.03.06.AM.webm
Checklist
codecheckpassed (See contributing)