Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unreferenced switching-physics-engine tutorial and fix broken … #684

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Remove unreferenced switching-physics-engine tutorial and fix broken … #684

merged 1 commit into from
Sep 13, 2024

Conversation

shameekganguly
Copy link
Contributor

🦟 Bug fix

Fixes #

Summary

04-switching_physics_engine is unreferenced in the tutorials page. Instead the 04_physics_engines tutorial is referenced and points to a similar tutorial in gz-sim, but the link is broken. In this change, I've removed the 04-switching_physics_engine tutorial and fixed the link in the 04_physics_engines tutorial.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@shameekganguly
Remove unreferenced switching-physics-engine tutorial and fix broken …
1ad8bd4 
…link in 04_physics_engines

Signed-off-by: Shameek Ganguly <shameekarcanesphinx@gmail.com>
@shameekganguly shameekganguly requested review from ahcorde and removed request for azeey and scpeters September 13, 2024 18:43
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Sep 13, 2024
@shameekganguly shameekganguly mentioned this pull request Sep 13, 2024
Closed
azeey
azeey approved these changes Sep 13, 2024
View reviewed changes
tutorials/04_physics_engines.md Show resolved Hide resolved
@azeey azeey merged commit c5f2954 into gazebosim:gz-physics8 Sep 13, 2024
11 checks passed
@shameekganguly shameekganguly mentioned this pull request Sep 13, 2024
Closed
@azeey azeey mentioned this pull request Dec 20, 2024
Closed
8 tasks
@azeey
Copy link
Contributor

azeey commented Dec 20, 2024

@Mergifyio backport gz-physics7

@mergify Mergify
Copy link

mergify bot commented Dec 20, 2024 •
edited
Loading

backport gz-physics7

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 20, 2024
@shameekganguly @mergify
Remove unreferenced switching-physics-engine tutorial and fix broken …
e6f46ba 
…link in 04_physics_engines (#684)

Signed-off-by: Shameek Ganguly <shameekarcanesphinx@gmail.com>
(cherry picked from commit c5f2954)

# Conflicts:
#	tutorials/04-switching-physics-engines.md
@mergify mergify bot mentioned this pull request Dec 20, 2024
Merged
8 tasks
azeey pushed a commit that referenced this pull request Dec 20, 2024
@shameekganguly @azeey
Remove unreferenced switching-physics-engine tutorial and fix broken …
d4a335a 
…link in 04_physics_engines (#684)

Signed-off-by: Shameek Ganguly <shameekarcanesphinx@gmail.com>
(cherry picked from commit c5f2954)

# Conflicts:
#	tutorials/04-switching-physics-engines.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 approved these changes

@azeey azeey azeey approved these changes

@ahcorde ahcorde Awaiting requested review from ahcorde

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees
No one assigned
Labels
🏛️ ionic Gazebo Ionic
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shameekganguly @azeey @iche033