Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CTAD compile warnings #663

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Fix CTAD compile warnings #663

merged 2 commits into from
Jul 8, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jul 1, 2024

🦟 Bug fix

Summary

Fixes the following error when compiling with the -Wctad-maybe-unsupported flag

physics/bullet_featherstone/src/JointFeatures.cc:179:7: error: 'math::Vector3' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported]

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033
Fix compile warning
3ad355c 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 requested review from azeey, mxgrey and scpeters as code owners July 1, 2024 17:25
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jul 1, 2024
@ahcorde ahcorde enabled auto-merge (squash) July 1, 2024 17:43
@azeey azeey removed their request for review July 2, 2024 21:59
@ahcorde ahcorde merged commit fa53310 into gz-physics7 Jul 8, 2024
8 of 9 checks passed
@ahcorde ahcorde deleted the fix_ctad branch July 8, 2024 17:23
@scpeters scpeters mentioned this pull request Aug 26, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

@ahcorde ahcorde ahcorde approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey

Assignees
No one assigned
Labels
🎵 harmonic Gazebo Harmonic
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iche033 @ahcorde @scpeters