Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify use of FeatureList aliases in tests #493

Draft
wants to merge 1 commit into
base: gz-physics6
Choose a base branch
from

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Mar 21, 2023

Summary

Using TYPED_TESTS for these tests seems overkill since only one type is being tested. The same can be accomplished by creating aliases to the desired FeatureLists and using those aliases with TEST_F.

TODO

  • Update other common tests once we have feedback on this PR.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Mar 21, 2023
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #493 (6766cce) into gz-physics6 (930a223) will not change coverage.
The diff coverage is n/a.

❗ Current head 6766cce differs from pull request most recent head 6bb63ee. Consider uploading reports for the commit 6bb63ee to get more accurate results

@@             Coverage Diff              @@
##           gz-physics6     #493   +/-   ##
============================================
  Coverage        75.56%   75.56%           
============================================
  Files              142      142           
  Lines             7191     7191           
============================================
  Hits              5434     5434           
  Misses            1757     1757           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scpeters
Copy link
Member

I guess TYPED_TEST would be helpful if we were testing 2f, 2d, and 3f variants in addition to 3d? So far, we have been focusing on 3d, so this seems ok, but may be something we want to revisit

@azeey azeey self-assigned this Apr 12, 2023
@azeey azeey added beta Targeting beta release of upcoming collection and removed beta Targeting beta release of upcoming collection labels Jul 31, 2023
scpeters added a commit that referenced this pull request Nov 2, 2023
Minor refactor based on #493.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@azeey azeey added beta Targeting beta release of upcoming collection and removed beta Targeting beta release of upcoming collection labels Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants