Add an example to the sourceNodes docs #8585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSchau
reviewed
Sep 27, 2018
| * } | ||
| * | ||
| * const nodeContent = JSON.stringify(myData) | ||
| * const nodeContentDigest = crypto |
There was a problem hiding this comment.
Unrelated, but I think you mentioned it too... we use this algorithm all over the place, so it's probably worth passing that to various APIs or something, e.g.
const createContentDigest = obj => crypto
.createHash(`md5`)
.update(obj)
.digest(`hex`)There was a problem hiding this comment.
👍 to that, here's an issue #8587
lipis
added a commit
to lipis/gatsby
that referenced
this pull request
Sep 27, 2018
* 'master' of github.com:gatsbyjs/gatsby: Add blog post on v2 reach router (gatsbyjs#8508) feat: add self to community page (gatsbyjs#8572) feat: update sites.yml (gatsbyjs#8589) Add an example to the sourceNodes docs (gatsbyjs#8585) chore(release): Publish fix: add compat fix for gatsby-cli v2 with gatsby v1 (gatsbyjs#8581) fix: fix unhandled rejection when no browser found when running with --open flag (gatsbyjs#8507) Fix writing out new page information (so new pages hot reload) during development (gatsbyjs#8570) Run coverage at the end of jest and configure thresholds (gatsbyjs#8371) chore(release): Publish chore: update gatsby-source-drupal version in using-drupal example (gatsbyjs#8497) Typo fix in gatsby-source-graphql/README.md (gatsbyjs#8562)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add usable example code to the sourceNodes API docs. The aim is to show the essentials of sourcing / creating a node without trying to do anything fancy or clever.
Refs: https://twitter.com/xjamundx/status/1045036899646111744?s=19
Thanks @octalmage for linking to https://github.com/jamesdanylik/gatsby-source-git-commit/blob/master/gatsby-node.js, I adapted my first version based on some of the ideas in there. Thanks @LekoArts for the review in Discord :)