Compat fix for gatsby-cli v2 with gatsby v1 #8581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-allanson
changed the title
m-allanson
commented
Sep 27, 2018
| let majorVersion | ||
| try { | ||
| let packagePath = require.resolve( | ||
| path.join(process.cwd(), `node_modules`, `gatsby`, `package.json`) |
There was a problem hiding this comment.
Not sure how reliable this is... it will at least fail silently.
m-allanson
commented
Sep 27, 2018
| const DEFAULT_BROWSERS = | ||
| installedGatsbyVersion() === 1 | ||
| ? [`> 1%`, `last 2 versions`, `IE >= 9`] | ||
| : [`>0.25%`, `not dead`] |
There was a problem hiding this comment.
This defaults to the Gatsby v2 query unless we definitely know this is a v1 site.
pieh
reviewed
Sep 27, 2018
| let packagePath = require.resolve( | ||
| path.join(process.cwd(), `node_modules`, `gatsby`, `package.json`) | ||
| ) | ||
| const packageInfo = JSON.parse(fs.readFileSync(packagePath)) |
There was a problem hiding this comment.
You can do require(`gatsby/package.json`) like in here I think:
There was a problem hiding this comment.
Oh yeah, straight up require. Thanks 😅
I think this still needs to use process.cwd() to provide an absolute path - otherwise the require doesn't resolve the local node_modules directory from a globally installed gatsby-cli. Maybe there's a neater way?
lipis
added a commit
to lipis/gatsby
that referenced
this pull request
Sep 27, 2018
* 'master' of github.com:gatsbyjs/gatsby: Add blog post on v2 reach router (gatsbyjs#8508) feat: add self to community page (gatsbyjs#8572) feat: update sites.yml (gatsbyjs#8589) Add an example to the sourceNodes docs (gatsbyjs#8585) chore(release): Publish fix: add compat fix for gatsby-cli v2 with gatsby v1 (gatsbyjs#8581) fix: fix unhandled rejection when no browser found when running with --open flag (gatsbyjs#8507) Fix writing out new page information (so new pages hot reload) during development (gatsbyjs#8570) Run coverage at the end of jest and configure thresholds (gatsbyjs#8371) chore(release): Publish chore: update gatsby-source-drupal version in using-drupal example (gatsbyjs#8497) Typo fix in gatsby-source-graphql/README.md (gatsbyjs#8562)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gatsby v1 includes postcss-next which uses an older version of browserslist. This means the default browserslist query
["> 0.25%", "not dead"]won't work in Gatsby v1. This causes an error when you havegatsby-cliv2 installed and you're working on a Gatsby v1 site.Fixes #8575
Refs #8560
Refs #7144