feat(gatsby-plugin-google-gtag): Add delayOnRouteUpdate option
#37017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
|
I'm not really sure about what's causing this test failure. I don't think this code change (extra setTimeout) should be breaking anything, since the function being called just invokes the Google pageview event, and the syntax is correct as far as I can tell. |
Simon-Tang
force-pushed
the
feat/gatsby-plugin-google-gtag-delayOnRouteUpdate
branch
from
1749cdc to
2de4641
Compare
|
I think these are probably just flaky tests, reran and the original failure passed. These changes were already in use for the last few years in the old plugin, though. |
LekoArts
suggested changes
Nov 16, 2022
LekoArts
added
topic: plugins-analytics
Simon-Tang
force-pushed
the
feat/gatsby-plugin-google-gtag-delayOnRouteUpdate
branch
from
2de4641 to
7ec55ed
Compare
LekoArts
approved these changes
Nov 17, 2022
LekoArts
changed the title
delayOnRouteUpdate option
This was referenced Nov 22, 2022
Open
Open
Open
This was referenced Nov 22, 2022
Open
Open
Open
This was referenced Nov 22, 2022
Open
Open
This was referenced Nov 23, 2022
Open
Open
This was referenced Nov 23, 2022
Open
Open
Open
Open
Open
Open
This was referenced Nov 23, 2022
Open
Open
Open
This was referenced Apr 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a new
delayOnRouteUpdateoption togatsby-plugin-google-gtag, which is needed for correct pageview events when page transitions are in use. (e.g. with https://www.gatsbyjs.com/plugins/gatsby-plugin-transition-link/). Without this parameter, for sites that have route change animations, pageview events are logged based on the old page instead of the new page.This ports over a change that I made to the previous (now-deprecated)
gatsby-plugin-google-analytics: #15610. However, I've renamed the option todelayOnRouteUpdatewhich I think is more descriptive.Documentation
Updated the README for this plugin, similarly to #15610.
Related Issues
Fixes #15504