feat(gatsby-plugin-google-analytics): Add pageTransitionDelay option #15610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardpeet
previously approved these changes
Jul 11, 2019
Contributor
wardpeet
left a comment
wardpeet
left a comment
There was a problem hiding this comment.
Awesome work! I added a few changes to make things a bit more simple.
Nothing special, just a bit of cleanup 💪
packages/gatsby-plugin-google-analytics/src/__tests__/gatsby-browser.js
Outdated
Show resolved
Hide resolved
packages/gatsby-plugin-google-analytics/src/__tests__/gatsby-browser.js
Outdated
Show resolved
Hide resolved
wardpeet
dismissed
their stale review
wrong button :'( should have pushed comment
Co-Authored-By: Ward Peeters <ward@coding-tech.com>
Contributor
Author
|
Good catches @wardpeet, thanks! |
wardpeet
approved these changes
Jul 12, 2019
Contributor
wardpeet
left a comment
wardpeet
left a comment
There was a problem hiding this comment.
Awesome! <3 Also 💯 on the written tests! We love tests 😄
Contributor
|
fixed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
pageTransitionDelayoption togatsby-plugin-google-analyticsto delay the "Page View" event when necessary for page transitions.Related Issues
#15504 - contains more context.