Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): revert #26636; and pin uuid to v3.4.0 #26824

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Conversation

pvdz
Copy link
Contributor

@pvdz pvdz commented Sep 8, 2020

Note: this was a manual revert since github would not let me automate it.

The bump to v8 as applied in #26636 gave us no benefits and are giving problems with imports in certain cases. Maintainers have made it clear they won't offer any support for node 13, which we will want to support for a while as well.

In due time we'll replace this library with something simpler as the maintenance burden will be too high. For now we revert and pin to 3.4.0, the last stable version that does what we want.

Fixes #26812

The bump to v8 as applied in #26636 gave us no benefits and are giving problems with imports in certain cases. Maintainers have made it clear they won't offer any support for node 13, which we will want to support for a while as well.

In due time we'll replace this library with something simpler as the maintenance burden will be too high. For now we revert and pin to 3.4.0, the last stable version that does what we want.

Fixes #26812
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 8, 2020
@pvdz pvdz added topic: npm* and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Sep 8, 2020
@gatsbyjs gatsbyjs deleted a comment from gatsby-cloud bot Sep 8, 2020
@gatsbyjs gatsbyjs deleted a comment from gatsby-cloud bot Sep 8, 2020
@gatsbyjs gatsbyjs deleted a comment from gatsby-cloud bot Sep 8, 2020
@pvdz pvdz added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Sep 8, 2020
@pvdz pvdz mentioned this pull request Sep 8, 2020
Copy link
Contributor

@jamo jamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gatsby-cloud
Copy link

gatsby-cloud bot commented Sep 8, 2020

Gatsby Cloud Build Report

gatsby

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 21m

@gatsbybot gatsbybot merged commit 25b73ad into master Sep 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the uuidno branch September 8, 2020 13:45
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
…s#26824)

The bump to v8 as applied in gatsbyjs#26636 gave us no benefits and are giving problems with imports in certain cases. Maintainers have made it clear they won't offer any support for node 13, which we will want to support for a while as well.

In due time we'll replace this library with something simpler as the maintenance burden will be too high. For now we revert and pin to 3.4.0, the last stable version that does what we want.

Fixes gatsbyjs#26812
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot run Gatsby on Mac
3 participants