Chore: uuid major upgrade #26636
Chore: uuid major upgrade #26636
Conversation
gatsbot
bot
added
the
status: triage needed
|
@herecydev can you confirm that the bundle did not grow to include the entire uuid library? There are two cases in the PR where |
pvdz
added
topic: npm*
and removed
status: triage needed
|
I'll do my best to work that out |
|
Peter, just so I'm clear are you talking about uuid being in the commons bundle? If so, I don't think it'll ever get bundled as it's only used in the "gatsby-node" side of gatsby if that makes sense. I double checked in the bundle but couldn't see anything in there relating to uuid |
|
Great, thanks :) |
|
Published in |
The bump to v8 as applied in #26636 gave us no benefits and are giving problems with imports in certain cases. Maintainers have made it clear they won't offer any support for node 13, which we will want to support for a while as well. In due time we'll replace this library with something simpler as the maintenance burden will be too high. For now we revert and pin to 3.4.0, the last stable version that does what we want. Fixes #26812
|
This change is being reverted in #26824 because the ESM changes applied in v7/v8 are causing problems and we're not expecting support from the maintainers. Additionally, there's no real benefit from bumping the dep version so we're just gonna pin it to 3.4.0 and move on, ultimately replacing it with something custom. In all use cases of this library we mostly care about generating a random string, not an actual uuid. |
The bump to v8 as applied in #26636 gave us no benefits and are giving problems with imports in certain cases. Maintainers have made it clear they won't offer any support for node 13, which we will want to support for a while as well. In due time we'll replace this library with something simpler as the maintenance burden will be too high. For now we revert and pin to 3.4.0, the last stable version that does what we want. Fixes #26812
…s#26824) The bump to v8 as applied in gatsbyjs#26636 gave us no benefits and are giving problems with imports in certain cases. Maintainers have made it clear they won't offer any support for node 13, which we will want to support for a while as well. In due time we'll replace this library with something simpler as the maintenance burden will be too high. For now we revert and pin to 3.4.0, the last stable version that does what we want. Fixes gatsbyjs#26812
Relevant changelog: https://github.com/uuidjs/uuid#upgrading-from-uuid3x