ci: produce jest xml reports only in azure pipelines #10160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In gatsbyjs#10128, we added test report tasks to Azure pipelines. Unfortunately, this adds some additional overhead and coverage type stuff in _local_ development that we probably don't want. This PR addresses this issue, and conditionally detects whether running in CI. If running in CI (e.g. Azure Pipelines, Circle, etc.) it will add the additional coverage reporter and coverage functionality. Note: this is currently blocked by watson/ci-info#22
DSchau
approved these changes
Nov 27, 2018
jest.config.js
Outdated
| @@ -31,7 +31,7 @@ module.exports = { | |||
| moduleNameMapper: { | |||
| "^highlight.js$": `<rootDir>/node_modules/highlight.js/lib/index.js`, | |||
| }, | |||
| collectCoverage: true, | |||
| collectCoverage: !!process.env.GENERATE_JEST_REPORT, | |||
There was a problem hiding this comment.
Nit, but could we hoist this up to something like
const useCoverage = !!process.env.GENERATE_JEST_REPORT
// use elsewhereThere was a problem hiding this comment.
👍 done (at least I hope I did what you meant ;) )
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
* test: do not report coverage unless in CI In gatsbyjs#10128, we added test report tasks to Azure pipelines. Unfortunately, this adds some additional overhead and coverage type stuff in _local_ development that we probably don't want. This PR addresses this issue, and conditionally detects whether running in CI. If running in CI (e.g. Azure Pipelines, Circle, etc.) it will add the additional coverage reporter and coverage functionality. Note: this is currently blocked by watson/ci-info#22 * add GENERATE_JEST_REPORT env var and use it with azure pipelines * use var to hold normalized (boolean) val from env var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
temporary alternative to #10140 (until
ci-infosupports azure pipelines)/cc @DSchau