-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding test report tasks to Azure pipelines #10128
Conversation
Here is the test report you get for the build that ran on this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vagisha-nidhi!
Holy buckets, @vagisha-nidhi — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
In gatsbyjs#10128, we added test report tasks to Azure pipelines. Unfortunately, this adds some additional overhead and coverage type stuff in _local_ development that we probably don't want. This PR addresses this issue, and conditionally detects whether running in CI. If running in CI (e.g. Azure Pipelines, Circle, etc.) it will add the additional coverage reporter and coverage functionality. Note: this is currently blocked by watson/ci-info#22
* test: do not report coverage unless in CI In #10128, we added test report tasks to Azure pipelines. Unfortunately, this adds some additional overhead and coverage type stuff in _local_ development that we probably don't want. This PR addresses this issue, and conditionally detects whether running in CI. If running in CI (e.g. Azure Pipelines, Circle, etc.) it will add the additional coverage reporter and coverage functionality. Note: this is currently blocked by watson/ci-info#22 * add GENERATE_JEST_REPORT env var and use it with azure pipelines * use var to hold normalized (boolean) val from env var
<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. --> **What kind of change does this PR introduce?** <!-- E.g. a bugfix, feature, refactoring, build related change, etc… --> This PR is related to the issue gatsbyjs#10103 The PR helps to publish test results for reporting in Azure Pipelines. **Summary** <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> <!-- Try to link to an open issue for more information. --> Azure Pipelines provides excellent reporting capabilities that can be leveraged by this PR. An example report is shown in the image below. ![image](https://user-images.githubusercontent.com/13175100/48767951-e8a73580-ecdd-11e8-8e6a-20d7767d7c1b.png) A screenshot for code coverage : ![image](https://user-images.githubusercontent.com/13175100/48795657-938e1280-ed23-11e8-88d0-bf94f610d774.png) **Does this PR introduce a breaking change?** No
* test: do not report coverage unless in CI In gatsbyjs#10128, we added test report tasks to Azure pipelines. Unfortunately, this adds some additional overhead and coverage type stuff in _local_ development that we probably don't want. This PR addresses this issue, and conditionally detects whether running in CI. If running in CI (e.g. Azure Pipelines, Circle, etc.) it will add the additional coverage reporter and coverage functionality. Note: this is currently blocked by watson/ci-info#22 * add GENERATE_JEST_REPORT env var and use it with azure pipelines * use var to hold normalized (boolean) val from env var
What kind of change does this PR introduce?
This PR is related to the issue #10103
The PR helps to publish test results for reporting in Azure Pipelines.
Summary
Azure Pipelines provides excellent reporting capabilities that can be leveraged by this PR.
An example report is shown in the image below.
A screenshot for code coverage :
Does this PR introduce a breaking change?
No