Skip to content

Fix brittle test assertions in custom marker function tests #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gatopeich merged 2 commits into from
Feb 13, 2026
Merged

Fix brittle test assertions in custom marker function tests #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e14314
Initial plan
Claude Feb 12, 2026
9623cce
Fix brittle test assertions in custom marker function tests
Claude Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions test/jasmine/tests/drawing_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,10 +668,10 @@ describe('gradients', function() {
}
}])
.then(function() {
// Marker functions are called once per point (3 points = 3 calls).
// With selected.marker.size, selectedPointStyle triggers a second pass (6 calls).
expect(receivedArgs.length === 3 || receivedArgs.length === 6).toBe(true,
'Expected 3 or 6 calls, got ' + receivedArgs.length);
// Marker functions are called once per point (3 points minimum).
// selectedPointStyle may trigger additional passes.
expect(receivedArgs.length >= 3).toBe(true,
'Expected at least 3 calls, got ' + receivedArgs.length);

// Verify r is passed correctly
expect(typeof receivedArgs[0].r).toBe('number');
Expand Down Expand Up @@ -708,10 +708,10 @@ describe('gradients', function() {
}
}])
.then(function() {
// Marker functions are called once per point (3 points = 3 calls).
// With selected.marker.size, selectedPointStyle triggers a second pass (6 calls).
expect(receivedData.length === 3 || receivedData.length === 6).toBe(true,
'Expected 3 or 6 calls, got ' + receivedData.length);
// Marker functions are called once per point (3 points minimum).
// selectedPointStyle may trigger additional passes.
expect(receivedData.length >= 3).toBe(true,
'Expected at least 3 calls, got ' + receivedData.length);

// Verify all expected customdata types were received
var receivedTypes = receivedData.map(function(d) { return d ? d.type : null; });
Expand Down