Add shared folder to artifacts

docs/GetStarted.md

@@ -4,6 +4,7 @@
   - [Create a Test](#create-a-test)
     - [Input Contract](#input-contract)
     - [Export Contract](#export-contract)
+    - [Shared Folder](#shared-folder)
     - [Images](#images)
   - [Create a Testrun](#create-a-testrun)
   - [Configuration](#configuration)
@@ -117,6 +118,10 @@ It then automatically uploads these documents to an index named like the TestDef
       { "key3": 5 }
     ```
 
+### Shared Folder
+
+Data that is stored in `TM_SHARED_PATH` location, can be accessed from within any testflow step of a the workflow. This is essential if e.g. a test flow step needs to evaluate the output of the previously finished test flow step. This folder is also available as an artifact in the Argo UI.
+
 ### Images
 
 The Testmachinery provides some images to run your Integration Tests (Dockerfiles can be found in hack/images).

pkg/testmachinery/testdefinition/testdefinition.go

@@ -91,6 +91,10 @@ func New(def *tmv1beta1.TestDefinition, loc Location, fileName string) *TestDefi
 					Name: "kubeconfigs",
 					Path: testmachinery.TM_KUBECONFIG_PATH,
 				},
+				{
+					Name: "sharedFolder",
+					Path: testmachinery.TM_SHARED_PATH,
+				},
 			},
 		},
 		Outputs: argov1.Outputs{
@@ -198,6 +202,11 @@ func (td *TestDefinition) AddSerialStdOutput() {
 		Path: testmachinery.TM_KUBECONFIG_PATH,
 	}
 	td.AddOutputArtifacts(kubeconfigArtifact)
+	sharedFolderArtifact := argov1.Artifact{
+		Name: "sharedFolder",
+		Path: testmachinery.TM_SHARED_PATH,
+	}
+	td.AddOutputArtifacts(sharedFolderArtifact)
 }
 
 // AddConfig adds the config elements of different types (environment variable) to the TestDefinitions's template.

pkg/testmachinery/testflow/node.go

@@ -82,6 +82,10 @@ func (n *Node) addTask(lastSerialNode, rootNode *Node) {
 			Name: "kubeconfigs",
 			From: fmt.Sprintf("{{tasks.%s.outputs.artifacts.kubeconfigs}}", lastSerialNode.Task.Name),
 		},
+		{
+			Name: "sharedFolder",
+			From: fmt.Sprintf("{{tasks.%s.outputs.artifacts.sharedFolder}}", lastSerialNode.Task.Name),
+		},
 	}
 
 	if n.TestDefinition.Location.Type() != tmv1beta1.LocationTypeLocal {

pkg/testmachinery/types.go

@@ -24,7 +24,10 @@ import (
 
 const (
 	// TM_KUBECONFIG_PATH is the path where kubeconfigs are mounted to tests.
-	TM_KUBECONFIG_PATH = "/tmp/env/kubeconfig"
+	TM_KUBECONFIG_PATH = "/tmp/tm/kubeconfig"
+
+	// TM_SHARED_PATH is the path to a shared folder, where content is shared among the workflow steps
+	TM_SHARED_PATH = "/tmp/tm/shared"
 
 	// TM_REPO_PATH is the path where the repo/location is mounted to the tests.
 	TM_REPO_PATH = "/src"

test/controller/testflow/testflow_suite_test.go

@@ -16,6 +16,7 @@ package testflow_test
 
 import (
 	"context"
+	"fmt"
 	"os"
 	"strings"
 	"testing"
@@ -177,6 +178,52 @@ var _ = Describe("Testflow execution tests", func() {
 		})
 	})
 
+	Context("File created in shared folder", func() {
+		sharedFilePath := fmt.Sprintf("%s/%s", testmachinery.TM_SHARED_PATH, "test")
+		It("should be visible from withing another step", func() {
+			ctx := context.Background()
+			defer ctx.Done()
+			tr := resources.GetBasicTestrun(namespace, commitSha)
+			tr.Spec.TestFlow = [][]tmv1beta1.TestflowStep{
+				// create file in shared folder
+				{
+					{
+						Name: "check-file-testdef",
+						Config: []tmv1beta1.ConfigElement{
+							{
+								Type:  tmv1beta1.ConfigTypeEnv,
+								Name:  "FILE",
+								Value: sharedFilePath,
+							},
+							{
+								Type:  tmv1beta1.ConfigTypeFile,
+								Name:  "TEST_NAME",
+								Value: "dGVzdAo=", // base64 encoded 'test' string
+								Path:  sharedFilePath,
+							},
+						},
+					},
+				},
+				// check in a another step if file exists in shared folder
+				{
+					{
+						Name: "check-file-testdef",
+						Config: []tmv1beta1.ConfigElement{
+							{
+								Type:  tmv1beta1.ConfigTypeEnv,
+								Name:  "FILE",
+								Value: sharedFilePath,
+							},
+						},
+					},
+				},
+			}
+			tr, _, err := utils.RunTestrun(ctx, tmClient, tr, argov1.NodeSucceeded, namespace, maxWaitTime)
+			defer utils.DeleteTestrun(tmClient, tr)
+			Expect(err).ToNot(HaveOccurred())
+		})
+	})
+
 	Context("config", func() {
 		Context("type environment variable", func() {
 			It("should mount a config as environment variable", func() {