Add shared folder to artifacts #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schrodit
suggested changes
Mar 26, 2019
OlegLoewen
force-pushed
the
addSharedFolderForFlowSteps
branch
2 times, most recently
from
42a50bf to
b1ef7c0
Compare
OlegLoewen
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
OlegLoewen
force-pushed
the
addSharedFolderForFlowSteps
branch
3 times, most recently
from
480fae5 to
e2f1db1
Compare
OlegLoewen
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
OlegLoewen
force-pushed
the
addSharedFolderForFlowSteps
branch
from
e2f1db1 to
a271b3a
Compare
dguendisch
requested changes
Apr 1, 2019
pkg/testmachinery/types.go
Outdated
| TM_KUBECONFIG_PATH = "/tmp/env/kubeconfig" | ||
| TM_KUBECONFIG_PATH = "/tmp/tm/kubeconfig" | ||
|
|
||
| // TM_KUBECONFIG_PATH is the path where kubeconfigs are mounted to tests. |
There was a problem hiding this comment.
should be an own comment (copy/paste) :)
OlegLoewen
force-pushed
the
addSharedFolderForFlowSteps
branch
from
7646bf0 to
c84c27c
Compare
dguendisch
approved these changes
Apr 1, 2019
schrodit
suggested changes
Apr 1, 2019
| @@ -177,6 +178,54 @@ var _ = Describe("Testflow execution tests", func() { | |||
| }) | |||
| }) | |||
|
|
|||
| Context("sharedFolder", func() { | |||
| sharedFilePath := fmt.Sprintf("%s/%s", testmachinery.TM_SHARED_PATH, "test") | |||
There was a problem hiding this comment.
move to test if not needed in other tests
OlegLoewen
force-pushed
the
addSharedFolderForFlowSteps
branch
from
c84c27c to
1e287ec
Compare
OlegLoewen
force-pushed
the
addSharedFolderForFlowSteps
branch
from
e545afc to
41156fb
Compare
schrodit
approved these changes
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds shared folder which can be used across the flow steps.
Release note: