Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade to Golang 1.15 #82

Merged
merged 1 commit into from
Feb 24, 2021
Merged

Downgrade to Golang 1.15 #82

merged 1 commit into from
Feb 24, 2021

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Feb 24, 2021

How to categorize this PR?

/area delivery
/kind regression
/priority normal

What this PR does / why we need it:
Go 1.16 comes with import restrictions which cause the following errors:

github.com/gardener/terraformer/hack imports
	github.com/gardener/gardener/.github: malformed import path "github.com/gardener/gardener/.github": leading dot in path element
github.com/gardener/terraformer/hack imports
	github.com/gardener/gardener/.github/ISSUE_TEMPLATE: malformed import path "github.com/gardener/gardener/.github/ISSUE_TEMPLATE": leading dot in path element
github.com/gardener/terraformer/hack imports
	github.com/gardener/gardener/hack/.ci: malformed import path "github.com/gardener/gardener/hack/.ci": leading dot in path element
make[1]: *** [/go/src/github.com/gardener/terraformer/Makefile:151: revendor] Error 1
make[1]: Leaving directory '/go/src/github.com/gardener/terraformer'
make: *** [Makefile:163: check-generate] Error 1

We gave feedback in golang/go#43985 and until a decision is made, we downgrade to 1.15 again.

Release note:

NONE

Due to import restrictions: golang/go#43985
@timuthy timuthy requested a review from a team as a code owner February 24, 2021 14:29
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 24, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 24, 2021
@gardener-robot gardener-robot added area/delivery Delivery related kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution priority/normal needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Feb 24, 2021
@timuthy
Copy link
Member Author

timuthy commented Feb 24, 2021

I suppose the verification will continue to fail because of the .pipeline_definition on the master branch?! 👀

Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

I suppose the verification will continue to fail because of the .pipeline_definition on the master branch?! 👀

Yes, unfortunately the pipeline definitions from the PR branch is not merged into the one from the base branch...
So we have to force-merge again. @rfranzke can you help with that?

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Feb 24, 2021
@rfranzke rfranzke merged commit cdfb7dd into master Feb 24, 2021
@rfranzke rfranzke deleted the fix.golang branch February 24, 2021 14:58
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/delivery Delivery related kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants