-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Golang to 1.16.2 #3739
Update Golang to 1.16.2 #3739
Conversation
I assume the |
Seems that golang/go#43985 is fixed in 1.16.1 (ref gardener/terraformer#82). |
a011a52
to
9ffe095
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for the reviews, I'll force-merge this PR and adapt the pipeline definition to properly reflect the 1.16 version. |
* Upgrade to Golang 1.16.2 * Replace packr with go:embed * Replace go-bindata with go:embed
* Upgrade to Golang 1.16.2 * Replace packr with go:embed * Replace go-bindata with go:embed
How to categorize this PR?
/area open-source dev-productivity
/kind enhancement
What this PR does / why we need it:
This PR updates the Golang version to v1.16.2 and eliminates both the
packr
andgo-bindata
libraries in favor of the nativego:embed
.Special notes for your reviewer:
/cc @ialidzhikov @timuthy
/squash
Release note: