Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Golang to 1.16.2 #3739

Merged
merged 3 commits into from
Mar 22, 2021
Merged

Update Golang to 1.16.2 #3739

merged 3 commits into from
Mar 22, 2021

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Mar 19, 2021 •
edited
Loading

How to categorize this PR?

/area open-source dev-productivity
/kind enhancement

What this PR does / why we need it:
This PR updates the Golang version to v1.16.2 and eliminates both the packr and go-bindata libraries in favor of the native go:embed.

Special notes for your reviewer:
/cc @ialidzhikov @timuthy
/squash

Release note:

The Golang version has been updated to `v1.16.2`. Support of `packr` and `go-bindata` has been dropped in favor of the native `go:embed`.

@rfranzke rfranzke requested review from a team as code owners March 19, 2021 10:48
@gardener-robot gardener-robot added needs/review area/dev-productivity Developer productivity related (how to improve development) area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 19, 2021
@rfranzke
Copy link
Member Author

I assume the verify step will fail because the pipeline is still using the 1.15 images of Golang which we only can change after merging this PR.

@vpnachev
Copy link
Member

Seems that golang/go#43985 is fixed in 1.16.1 (ref gardener/terraformer#82).

vpnachev
vpnachev approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

timebertt
timebertt approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Nice!
/lgtm

ialidzhikov
ialidzhikov approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke
Copy link
Member Author

Thanks for the reviews, I'll force-merge this PR and adapt the pipeline definition to properly reflect the 1.16 version.

@rfranzke rfranzke merged commit c50704b into gardener:master Mar 22, 2021
@rfranzke rfranzke deleted the enh/golang-1.16 branch March 22, 2021 18:53
@majst01 majst01 mentioned this pull request Apr 6, 2021
Closed
krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
@rfranzke
Update Golang to 1.16.2 (gardener#3739)
ad973a1 
* Upgrade to Golang 1.16.2

* Replace packr with go:embed

* Replace go-bindata with go:embed
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
@rfranzke
Update Golang to 1.16.2 (gardener#3739)
0756ed0 
* Upgrade to Golang 1.16.2

* Replace packr with go:embed

* Replace go-bindata with go:embed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpnachev vpnachev vpnachev approved these changes

@ialidzhikov ialidzhikov ialidzhikov approved these changes

@timebertt timebertt timebertt approved these changes

Assignees
No one assigned
Labels
area/dev-productivity Developer productivity related (how to improve development) area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rfranzke @vpnachev @ialidzhikov @timebertt @gardener-robot-ci-2 @gardener-robot