Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal for hot-update of resources (Instance / NIC / Disk) #761

Merged
merged 10 commits into from
Apr 4, 2023
Merged

Proposal for hot-update of resources (Instance / NIC / Disk) #761

merged 10 commits into from
Apr 4, 2023

Conversation

himanshu-kun
Copy link
Contributor

@himanshu-kun himanshu-kun commented Dec 6, 2022 •
edited
Loading

What this PR does / why we need it:
Proposal has been added to docs/proposal where we have talked about current drawbacks of machineClass (in context of tags specifically), and a way we could hot-update parameters for the resources MCM handles (VM,nics,disks). Hot-update means this fields would be updated for (VM, nics, disks) without any need to do any rolling update and create a new VM.
Some examples are:

  • tags
  • serviceAccount (in case of gcp VMs)
  • srcDest check (in case of aws)

Which issue(s) this PR fixes:
Fixes #
Proposal for #635

Special notes for your reviewer:

Release note:

Added proposal for hot-update of resources (instance/Nic/Disk)

@himanshu-kun himanshu-kun requested a review from a team as a code owner December 6, 2022 05:03
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Dec 6, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 6, 2022
@himanshu-kun himanshu-kun changed the title Proposal for consumption of non-rolling update VM/disk/nic parameters added Proposal for consumption of non-rolling update parameters of resources Dec 6, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 6, 2022
@vlerenc
Copy link
Member

vlerenc commented Dec 14, 2022

I miss a little bit a discussion around compatibility, transition, generally the stuff in #750. Is that because it's this one here is about an implementation proposal and the other ticket is expected "to be present in reader's mind"?

@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jan 10, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 10, 2023
@himanshu-kun @unmarshall
Apply suggestions from code review
e49339b 
Co-authored-by: Madhav Bhargava <madhav.bhargava@sap.com>
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 10, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 10, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 10, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 10, 2023
@himanshu-kun himanshu-kun mentioned this pull request Feb 24, 2023
Open
@himanshu-kun himanshu-kun self-assigned this Mar 7, 2023
@gardener-robot gardener-robot removed the size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) label Mar 28, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 28, 2023
@unmarshall unmarshall changed the title Proposal for consumption of non-rolling update parameters of resources Proposal for hot-update of resources (Instance / NIC / Disk) Mar 28, 2023
@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/l Size of pull request is large (see gardener-robot robot/bots/size.py) labels Mar 28, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 28, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 28, 2023
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Mar 31, 2023
@himanshu-kun
Copy link
Contributor Author

himanshu-kun commented Apr 3, 2023 •
edited
Loading

/reviewed ok-to-test

@gardener-robot gardener-robot added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 3, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 3, 2023
@himanshu-kun
Copy link
Contributor Author

The diagram is still incomplete.

  • it doesn't describe how to deal with ABA scenario
  • it doesn't describe the scenario of error from the UpdateMachine call
  • it updates thelastOperationState to Processing before the UpdateMachine is made, which was the alternate soln for ABA scenario and got rejected.

I think we don't need a diagram in this, as the proposal is quite descriptive and diagramatic details could be discussed once its picked up for implementation.

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 3, 2023
@unmarshall
Copy link
Contributor

I think we don't need a diagram in this, as the proposal is quite descriptive and diagramatic details could be discussed once its picked up for implementation.

I have removed the diagram as of now from this PR.

@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 3, 2023
unmarshall
unmarshall approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@unmarshall unmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Apr 4, 2023
@unmarshall unmarshall merged commit 657ffc9 into gardener:master Apr 4, 2023
@gardener-robot gardener-robot added status/closed Issue is closed (either delivered or triaged) and removed needs/second-opinion Needs second review by someone else labels Apr 4, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 4, 2023
@himanshu-kun himanshu-kun deleted the update-tags-proposal branch April 11, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unmarshall unmarshall unmarshall approved these changes

Assignees

@unmarshall unmarshall

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@himanshu-kun @vlerenc @unmarshall @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot @elankath