Improvements for User-managed network #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
|
@dkistner You have pull request review open invite, please check |
gardener-robot
added
reviewed/lgtm
|
@kon-angelo Could you please mention this issue/PR in the MCM issue that tracks the in-place update implementations done so far? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces improvements for when the machineClass specifies a subnet. It introduces an additional GET check to see if the port that has to be created is already there from a previous attempt and if so it reuses that port.
In addition:
it refactors
resolveServerNetworksinto 2 different ones. The first calculates the network arguments for the server creation and the second calculates the server ports that must be patched to accept pod network traffic.Fixes Patch server ports when adopting machines #23 by making the patching of server's ports happen on
GetMachineStatustoo. This is a similar approach to the one done in Disable SrcAndDestCheck on NAT Instances machine-controller-manager-provider-aws#39.Which issue(s) this PR fixes:
Fixes #23
Special notes for your reviewer:
Release note: