Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration field for alerting days #176

Merged
merged 4 commits into from
Jul 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ data:
regex: ^(cert_management_.+)$
action: keep

{{- if gt .Values.configuration.certExpirationAlertDays 0.0 }}
alerting_rules: |
cert-controller-manager.rules.yaml: |
groups:
Expand All @@ -44,8 +45,9 @@ data:
type: seed
visibility: operator
annotations:
description: Certificate in namespace {{ .Release.Namespace }} will be expired less than {{ .Values.configuration.certExpirationAlertDays }} days.
summary: SSL certificate will expire less than {{ .Values.configuration.certExpirationAlertDays }} days
description: Certificate in namespace {{ .Release.Namespace }} will expire in less than {{ .Values.configuration.certExpirationAlertDays }} days.
summary: TLS certificate will expire in less than {{ .Values.configuration.certExpirationAlertDays }} days
{{- end }}

dashboard_operators: |
cert-controller-manager-dashboard.json: |-
Expand Down
33 changes: 33 additions & 0 deletions docs/usage/alerting.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
---
title: Changing alerting settings
level: beginner
category: Networking
scope: operator
publishdate: 2023-07-20
tags: ["task"]
description: How to change the alerting on expiring certificates
---

# Changing alerting settings

Certificates are normally renewed automatically 30 days before they expire.
As a second line of defense, there is an alerting in Prometheus activated if the certificate is a few days
before expiration. By default, the alert is triggered 15 days before expiration.

You can configure the days in the `providerConfig` of the extension.
Setting it to 0 disables the alerting.

In this example, the days are changed to 3 days before expiration.

ScheererJ marked this conversation as resolved.
Show resolved Hide resolved
```yaml
kind: Shoot
...
spec:
extensions:
- type: shoot-cert-service
providerConfig:
apiVersion: service.cert.extensions.gardener.cloud/v1alpha1
kind: CertConfig
alerting:
certExpirationAlertDays: 3
```
3 changes: 3 additions & 0 deletions example/30-extension.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,6 @@ spec:
# enabled: false

#precheckNameservers: "10.0.0.53,10.123.56.53,8.8.8.8" # optional comma separated list of DNS server IP addresses if public DNS servers are not sufficient for prechecking DNS challenges

#alerting:
# certExpirationAlertDays: 13
45 changes: 45 additions & 0 deletions hack/api-reference/service.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,20 @@ string
challenge before calling ACME CA. Please consider to specify nameservers per issuer instead.</p>
</td>
</tr>
<tr>
<td>
<code>alerting</code></br>
<em>
<a href="#service.cert.extensions.gardener.cloud/v1alpha1.Alerting">
Alerting
</a>
</em>
</td>
<td>
<em>(Optional)</em>
<p>Alerting contains configuration for alerting of certificate expiration.</p>
</td>
</tr>
</tbody>
</table>
<h3 id="service.cert.extensions.gardener.cloud/v1alpha1.ACMEExternalAccountBinding">ACMEExternalAccountBinding
Expand Down Expand Up @@ -144,6 +158,37 @@ encoded data.</p>
</tr>
</tbody>
</table>
<h3 id="service.cert.extensions.gardener.cloud/v1alpha1.Alerting">Alerting
</h3>
<p>
(<em>Appears on:</em>
<a href="#service.cert.extensions.gardener.cloud/v1alpha1.CertConfig">CertConfig</a>)
</p>
<p>
<p>Alerting contains configuration for alerting of certificate expiration.</p>
</p>
<table>
<thead>
<tr>
<th>Field</th>
<th>Description</th>
</tr>
</thead>
<tbody>
<tr>
<td>
<code>certExpirationAlertDays</code></br>
<em>
int
</em>
</td>
<td>
<em>(Optional)</em>
<p>CertExpirationAlertDays are the number of days before the certificate expiration date an alert is triggered.</p>
</td>
</tr>
</tbody>
</table>
<h3 id="service.cert.extensions.gardener.cloud/v1alpha1.DNSChallengeOnShoot">DNSChallengeOnShoot
</h3>
<p>
Expand Down
9 changes: 9 additions & 0 deletions pkg/apis/service/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,15 @@ type CertConfig struct {
// PrecheckNameservers is used to specify a comma-separated list of DNS servers for checking availability for DNS
// challenge before calling ACME CA. Please consider to specify nameservers per issuer instead.
PrecheckNameservers *string

// Alerting contains configuration for alerting of certificate expiration.
Alerting *Alerting
}

// Alerting contains configuration for alerting of certificate expiration.
type Alerting struct {
// CertExpirationAlertDays are the number of days before the certificate expiration date an alert is triggered.
CertExpirationAlertDays *int
}

// IssuerConfig contains information for certificate issuers.
Expand Down
11 changes: 11 additions & 0 deletions pkg/apis/service/v1alpha1/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,17 @@ type CertConfig struct {
// challenge before calling ACME CA. Please consider to specify nameservers per issuer instead.
// +optional
PrecheckNameservers *string `json:"precheckNameservers,omitempty"`

// Alerting contains configuration for alerting of certificate expiration.
// +optional
Alerting *Alerting `json:"alerting,omitempty"`
}

// Alerting contains configuration for alerting of certificate expiration.
type Alerting struct {
// CertExpirationAlertDays are the number of days before the certificate expiration date an alert is triggered.
// +optional
CertExpirationAlertDays *int `json:"certExpirationAlertDays,omitempty"`
}

// IssuerConfig contains information for certificate issuers.
Expand Down
32 changes: 32 additions & 0 deletions pkg/apis/service/v1alpha1/zz_generated.conversion.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 26 additions & 0 deletions pkg/apis/service/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 26 additions & 0 deletions pkg/apis/service/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions pkg/controller/actuator.go
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,10 @@ func (a *actuator) createSeedResources(ctx context.Context, certConfig *service.
cfg["deactivateAuthorizations"] = *a.serviceConfig.ACME.DeactivateAuthorizations
}

if certConfig.Alerting != nil && certConfig.Alerting.CertExpirationAlertDays != nil {
cfg["certExpirationAlertDays"] = *certConfig.Alerting.CertExpirationAlertDays
}

certManagementConfig, err = chart.InjectImages(certManagementConfig, imagevector.ImageVector(), []string{v1alpha1.CertManagementImageName})
if err != nil {
return fmt.Errorf("failed to find image version for %s: %v", v1alpha1.CertManagementImageName, err)
Expand Down