Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration field for alerting days #176

Merged
merged 4 commits into from
Jul 24, 2023
Merged

Add configuration field for alerting days #176

merged 4 commits into from
Jul 24, 2023

Conversation

MartinWeindel
Copy link
Member

@MartinWeindel MartinWeindel commented Jul 20, 2023 •
edited
Loading

How to categorize this PR?

/area control-plane
/kind enhancement

What this PR does / why we need it:
Add configuration field for alerting days

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
follow-up of #174

Release note:

Add configuration field `certExpirationAlertDays` to allow overriding default value in shoot manifest.

@MartinWeindel MartinWeindel requested review from a team as code owners July 20, 2023 13:03
@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Jul 20, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 20, 2023
ScheererJ
ScheererJ reviewed Jul 20, 2023
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good already.

I just have a minor nit and a question.

charts/internal/shoot-cert-management-seed/templates/configmap-observability.yaml Outdated Show resolved Hide resolved
docs/usage/alerting.md Outdated Show resolved Hide resolved
docs/usage/alerting.md Show resolved Hide resolved
MartinWeindel and others added 2 commits July 20, 2023 15:45
@MartinWeindel @ScheererJ
Update charts/internal/shoot-cert-management-seed/templates/configmap…
b92014e 
…-observability.yaml

Co-authored-by: Johannes Scheerer <johannes.scheerer@sap.com>
@MartinWeindel @ScheererJ
Update docs/usage/alerting.md
28a5667 
Co-authored-by: Johannes Scheerer <johannes.scheerer@sap.com>
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 20, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 20, 2023
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 21, 2023
@gardener-robot gardener-robot removed the needs/second-opinion Needs second review by someone else label Jul 21, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 21, 2023
@MartinWeindel MartinWeindel merged commit e983c58 into master Jul 24, 2023
1 check passed
@MartinWeindel MartinWeindel deleted the config-alertdays branch July 24, 2023 06:58
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 24, 2023
MartinWeindel pushed a commit that referenced this pull request Apr 26, 2024
@gardener-robot-ci-2 @gardener-robot-ci-3 @MartinWeindel
Upgrade cert-management (#254)
1dafe3a 
from v0.14.1 to v0.14.2

**Release Notes**:
```bugfix user github.com/gardener/cert-management #176 @MartinWeindel
Fix regression for annotations on ingress resources: `dns.gardener.cloud/dnsnames` annotation must be ignored.
```

Co-authored-by: gardener-robot-ci-3 <gardener.ci.user3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MartinWeindel @ScheererJ @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot