Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection of minor improvements #618

Merged
merged 8 commits into from
Feb 17, 2016
Merged

Collection of minor improvements #618

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f22e339
ENHANCE: Added TensorWreathProduct
hulpke Jan 29, 2016
e5eb173
ENHANCE: DerivedSeries for certain infinite groups
hulpke Feb 5, 2016
679d0cf
ENHANCE: Fallback method for CopySubMatrix
hulpke Feb 12, 2016
2f6aafa
ENHANCE: Clarify persistence of ordering in action homomorphisms.
hulpke Feb 13, 2016
b64363b
ENHANCE: shortcuts in permutation factor group code.
hulpke Feb 15, 2016
79a08e1
Force a finiteness test in generic `PcgsElementaryAbelianSeries`
hulpke Feb 15, 2016
4289547
ENHANCE: Synonym Grobner for Groebner
hulpke Feb 15, 2016
b2d2bb2
ENHANCE: Print routine for words deals better with large generator po…
hulpke Feb 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ENHANCE: Fallback method for CopySubMatrix 
in case the representation is only Plist.
  • Loading branch information
@hulpke
hulpke committed Feb 15, 2016
commit 679d0cfb519b629aaa62ecfbf28383aaf1c540b5
14 changes: 14 additions & 0 deletions lib/matobjplist.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1172,6 +1172,20 @@ InstallMethod( CopySubMatrix, "for two plist matrices and four lists",
od;
end );

InstallOtherMethod( CopySubMatrix,
"for two plists -- fallback in case of bad rep.",
[ IsPlistRep, IsPlistRep and IsMutable,
IsList, IsList, IsList, IsList ],
function( m, n, srcrows, dstrows, srccols, dstcols )
local i;
# in this representation all access probably has to go through the
# generic method selection, so it is not clear whether there is an
# improvement in moving this into the kernel.
for i in [1..Length(srcrows)] do
n[dstrows[i]]{dstcols}:=m[srcrows[i]]{srccols};
od;
end );

InstallMethod( CopySubMatrix,
"for a plist matrix and a checking plist matrix and four lists",
[ IsPlistMatrixRep,
Expand Down