Collection of minor improvements #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- DerivedSubgroup for (subgroups of) fp groups sets the abelian invariants and tests whether the abelian quotinet is infinite - MaximalAbelianQuotient for fp groups sets the abelian invariants of the group - Derived series does not insist on comparing subgroups if termination can be assessed differently. This fixes the issue that was mentioned in gap-system#584.
in case the representation is only Plist.
A test for the crisp package assumes that PcgsElementaryAbelianSeries can be called for an fp group that does not yet know to be finite, and the solvability test does not imply finite. As the main library cannot edit this package test, this needs to be changed so the standard test suite runs through.
| @@ -485,6 +485,8 @@ DeclareOperation("GroebnerBasis", | |||
| DeclareOperation("GroebnerBasis",[IsPolynomialRingIdeal,IsMonomialOrdering]); | |||
| DeclareGlobalFunction("GroebnerBasisNC"); | |||
|
|
|||
| DeclareSynonym("GrobnerBasis",GroebnerBasis); | |||
There was a problem hiding this comment.
lib/helpbase.gi defines global variable TRANSATL which is currently
[ [ "atalogue", "atalog" ],
[ "olour", "olor" ],
[ "entre", "enter" ],
[ "isation", "ization" ],
[ "ise", "ize" ],
[ "abeling", "abelling" ],
[ "olvable", "oluble" ],
[ "yse", "yze" ] ] );
Do we want to add ["Groebner","Grobner"] pair there so the search ??Grobner will return all entries with Groebner? The only thing that stops me is that I do not know whether this spelling (or misspelling) is relevant to the Atlantic ocean...
There was a problem hiding this comment.
If that would not be considered as a gratuitous abouse of the language feature, I'd be happy to do so.
There was a problem hiding this comment.
Maxima uses Groebner in the text in the manual, but grobner as a name of the package and some functions that it provides, so perhaps this makes sense.
Further Gro(e)bner translation
…wers. This resolves a^10000, not (ab)^10000, but will already help in many cases. This addition comes riding shotgun on others but has been the source for recent complaints.
hulpke
added a commit
that referenced
this pull request
Feb 17, 2016
Collection of minor improvements Married, as no problems arose.
This was referenced Feb 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pull request to get the automatic tests.
e5eb and 2f6a are in response to reported problems.
There should be no obstacle (apart from the branch being on `master' to moving selected changes also to 4.8