Backport changes to stable-4.12 #5119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
show the degrees of the field extensions of the shown characters
... not just via a message printed to the user
Before this, `make doc` would end up in a GAP prompt, which is against any convention and makes it unusable in automation. Likewise, errors would just result in a break loop, instead of terminating with a non-zero exit code. This patch fixes this. It also suppresses the GAP banner for `make doc`. To take effect, packages need to update to this new version.
This broke the HAP test suite
The test suite reported a diff without this. Reported by Bill Allombert.
(and the other way round) by installing the current methods only for mutiplying with internal FFEs and adding new methods for multiplying with non-internal FFEs. (This addresses issue gap-system#5062.)
The two methods now give equivalent results when both are applicable (for a pc group and a finite prime field).
The `gen` directory is for things that are created by `make` and it is deleted by `make clean`. But `pkgconfig.h.in` is *not* generated by `make`. So it does not belong into `src` but rather into `gen`. Unfortunately GAP's `BuildPackages.sh` script runs `make clean` before `make`, which triggered this problematic behavior, causing build failures in `io` and `curlInterface`.
Suggested by Bill Allombert
Without this, the check failed with at least some compilers;
here is an error from Apple Clang:
conftest.c:34:28: error: result argument to overflow builtin must be
a pointer to a non-const integer ('int' invalid)
__builtin_mul_overflow(0,0,0);
^
And here with GCC 9.4:
conftest.c:34:28: error: argument 3 in call to function
'__builtin_mul_overflow' does not have pointer to integral type
34 | __builtin_mul_overflow(0,0,0);
| ^
... as it is not contained in release tarballs!
fingolfin
added
the
release notes: not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports a bunch of changes from
mastertostable-4.12:Displayfor a character table optionally shows the degrees of the character fields #5047make docterminates #5053Orbitswhen called with a range as seeds #5057AllHomomorphismsregression #5059IsFFEandIs8BitMatrixRep#5066AbsolutelyIrreducibleModulesfor a pc group and a finite prime field #5067GMP_PREFIXinsysinfo.gapfor package build systems #5079__builtin_mul_overflowcheck #5085