Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AbsolutelyIrreducibleModules for a pc group and a finite prime field #5067

Merged

Conversation

ThomasBreuer
Copy link
Contributor

@ThomasBreuer ThomasBreuer commented Sep 25, 2022

The two methods now give equivalent results when both are applicable (for a pc group and a finite prime field).

This resolves #5061.

The two methods now give equivalent results when both are applicable
(for a pc group and a finite prime field).
@ThomasBreuer ThomasBreuer added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes backport-to-4.12 labels Sep 25, 2022
@fingolfin
Copy link
Member

The testpackages failures are due to network problems and not caused by this PR. I'll try to re-run them now

@fingolfin fingolfin enabled auto-merge (rebase) September 26, 2022 08:27
@fingolfin fingolfin merged commit f9458e2 into gap-system:master Sep 26, 2022
@ThomasBreuer ThomasBreuer deleted the TB_AbsolutelyIrreducibleModules branch September 26, 2022 17:07
@fingolfin
Copy link
Member

Backported to stable-4.12 via commit dce0c1a

@fingolfin fingolfin changed the title fixed AbsolutelyIrreducibleModules for a pc group and a finite prime field Fix AbsolutelyIrreducibleModules for a pc group and a finite prime field Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-4.12-DONE kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

problem with AbsolutelyIrreducibleModules
3 participants