-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make more lib/matrix.gi code compatible with MatrixObj #3556
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
(Alternatively, one could just remove the lines checking IsEmpty(mat)
.)
True... actually, that made me wonder: Can non-square matrices to be diagonal or triangular? If so, what is the definition? For triangular, it seems our code is a bit asymmetric; e.g. |
130542a
to
bb6f23a
Compare
Concerning the definitions, the Reference Manual says:
(Of course the second "below" has to be replaced by "above".) Concerning the code, I will provide a pull request (also for correcting some more details of the documentation). |
I already provided such a pull request yesterday |
That is, PR #3559 fixes |
In particular powering of MatrixObjs now is fast, and we have generic methods for
IsDiagonalMat
,IsUpperTriangularMat
,IsLowerTriangularMat