Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IsUpperTriangularMat for non-square matrices #3559

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Fix IsUpperTriangularMat for non-square matrices #3559

merged 1 commit into from
Jul 12, 2019

Conversation

fingolfin
Copy link
Member

Also add some tests.

@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them topic: library labels Jul 11, 2019
PaulaHaehndel
PaulaHaehndel reviewed Jul 11, 2019
View reviewed changes
Copy link
Contributor

@PaulaHaehndel PaulaHaehndel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change of the matrix.gi is good.
I think an aditional non null matrix non quadratic example would be nice.

tst/testinstall/matrix.tst Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 84.306% when pulling b5faae0 on fingolfin:mh/fix-IsUpperTriangularMat into 608c6b8 on gap-system:master.

@ThomasBreuer ThomasBreuer merged commit 410a347 into gap-system:master Jul 12, 2019
@fingolfin fingolfin mentioned this pull request Jul 12, 2019
Merged
@fingolfin fingolfin deleted the mh/fix-IsUpperTriangularMat branch July 12, 2019 09:18
@PaulaHaehndel PaulaHaehndel mentioned this pull request Jul 23, 2019
Merged
@DominikBernhardt DominikBernhardt added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Aug 20, 2019
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulaHaehndel PaulaHaehndel PaulaHaehndel left review comments

@wilfwilson wilfwilson wilfwilson approved these changes

Assignees
No one assigned
Labels
kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes topic: library
Projects
None yet
Milestone
GAP 4.11.0
Development

Successfully merging this pull request may close these issues.
7 participants
@fingolfin @coveralls @wilfwilson @PaulaHaehndel @olexandr-konovalov @DominikBernhardt @ThomasBreuer