Replace GAP_ROOT_PATHS in tests with 'GAP_ROOT_PATH' #2898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2898 +/- ##
==========================================
- Coverage 83.8% 83.72% -0.08%
==========================================
Files 681 680 -1
Lines 346416 346634 +218
==========================================
- Hits 290303 290232 -71
- Misses 56113 56402 +289
|
ChrisJefferson
added
topic: kernel
release notes: to be added
fingolfin
reviewed
Oct 25, 2018
ChrisJefferson
force-pushed
the
gap_root_path_test
branch
from
8b258a3
to
f3378fa
Compare
|
Adjusted to print GAPROOT |
fingolfin
approved these changes
Oct 29, 2018
DominikBernhardt
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #2896.
I decided to use the string
'GAP_ROOT_PATH', rather thanGAPROOT, because GAP actually outputsGAPROOTin some places and I thought it might be better if the replacement isn't something that GAP already outputs as standard (also it more tightly ties it to theGAP_ROOT_PATHvariable. I put it in single quotes because otherwise you getGAP_ROOT_PATHlib/init.g, which looks bad, but I didn't really want to start stripping slashes (maybe I should)