Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace GAP_ROOT_PATHS in tests with 'GAP_ROOT_PATH' does not work with long paths #2981

Closed
olexandr-konovalov opened this issue Nov 9, 2018 · 1 comment · Fixed by #2987
Closed

Replace GAP_ROOT_PATHS in tests with 'GAP_ROOT_PATH' does not work with long paths #2981

olexandr-konovalov opened this issue Nov 9, 2018 · 1 comment · Fixed by #2987

Comments

@olexandr-konovalov
Copy link
Member

#2898 does not work when the path is too long - that's why it works on my laptop and Travis, but not on the Jenkins machine. It's not Jenkins related at all - if I log into kovacs and go into the build workspace, I see exactly the same in make testinstall:

########> Diff in /circa/scratch/gap-jenkins/workspace/GAP-pull-request-quickt\
est/GAPCOPTS/64build/GAPGMP/gmp/GAPTARGET/install/label/kovacs/GAP-pull-reques\
t-snapshot/tst/testinstall/opers/LocationFunc.tst:9
# Input is:
LocationFunc(Where);
# Expected output:
"GAPROOT/lib/error.g:79"
# But found:
"/circa/scratch/gap-jenkins/workspace/GAP-pull-request-quicktest/GAPCOPTS/64bu\
\
ild/GAPGMP/gmp/GAPTARGET/install/label/kovacs/GAP-pull-request-snapshot/lib/er\
\
ror.g:79"
########

I've instrumented lib/test.gi to print res and gaproot before calling res := ReplacedString(res, gaproot, "GAPROOT/"); and that's what I see

res=
"/circa/scratch/gap-jenkins/workspace/GAP-pull-request-quicktest/GAPCOPTS/64bu\
\
ild/GAPGMP/gmp/GAPTARGET/install/label/kovacs/GAP-pull-request-snapshot/lib/er\
\
ror.g:79"

gaproot=
/circa/scratch/gap-jenkins/workspace/GAP-pull-request-quicktest/GAPCOPTS/64bui\
ld/GAPGMP/gmp/GAPTARGET/install/label/kovacs/GAP-pull-request-snapshot/
@olexandr-konovalov olexandr-konovalov mentioned this issue Nov 9, 2018
Merged
@olexandr-konovalov
Copy link
Member Author

I suggest to revert #2898 and make test of LocationFunc checking that it returns the string which ends with /lib/error.g:32 instead of comparing the full string.

olexandr-konovalov pushed a commit to olexandr-konovalov/gap that referenced this issue Nov 9, 2018
Revert "Replace GAP_ROOT_PATHS in tests with 'GAP_ROOT_PATH'"
fff74a4 
This reverts commit 24a8e36.
It also makes the test of LocationFunc not depending on the
full path to the directory.

Closes gap-system#2981.
@olexandr-konovalov olexandr-konovalov mentioned this issue Nov 10, 2018
Merged
olexandr-konovalov pushed a commit to olexandr-konovalov/gap that referenced this issue Nov 10, 2018
Revert "Replace GAP_ROOT_PATHS in tests with 'GAP_ROOT_PATH'"
d34d52a 
This reverts commit 24a8e36.
It also makes the test of LocationFunc not depending on the
full path to the directory.

Closes gap-system#2981.
olexandr-konovalov pushed a commit to olexandr-konovalov/gap that referenced this issue Nov 11, 2018
Revert replacing GAP_ROOT_PATHS in tests
2609400 
This reverts replacing GAP_ROOT_PATHS in tests with 'GAP_ROOT_PATH',
made in commit 24a8e36. It happened
that such replacement does not work if the path is long enough to be
wrapped onto the next line.

The test of LocationFunc, added in the same commit, is preserved, but
made not depending on the full path to the directory.

Closes gap-system#2981.
fingolfin pushed a commit that referenced this issue Nov 12, 2018
@fingolfin
Revert replacing GAP_ROOT_PATHS in tests
ec440ce 
This reverts replacing GAP_ROOT_PATHS in tests with 'GAP_ROOT_PATH',
made in commit 24a8e36. It happened
that such replacement does not work if the path is long enough to be
wrapped onto the next line.

The test of LocationFunc, added in the same commit, is preserved, but
made not depending on the full path to the directory.

Closes #2981.
ssiccha pushed a commit to ssiccha/gap that referenced this issue Mar 27, 2019
@ssiccha
Revert replacing GAP_ROOT_PATHS in tests
b0a066f 
This reverts replacing GAP_ROOT_PATHS in tests with 'GAP_ROOT_PATH',
made in commit 24a8e36. It happened
that such replacement does not work if the path is long enough to be
wrapped onto the next line.

The test of LocationFunc, added in the same commit, is preserved, but
made not depending on the full path to the directory.

Closes gap-system#2981.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Partially revert "Replace GAP_ROOT_PATHS in tests with 'GAP_ROOT_PATH'" olexandr-konovalov/gap
1 participant
@olexandr-konovalov