Improve IsPackageLoaded #2877
Merged
Improve IsPackageLoaded #2877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First off, it now aborts immediately if the package is not loaded, and doesn't call the package's `AvailabilityTest` function (fixes gap-system#2862). This was achieved by not using `TestPackageAvailability` anymore, but rather `IsPackageMarkedForLoading`. The main difference to the latter now is this: We now record whether a package fully completed loading (in particular, we record whether its `init.g` and `read.g` executed without an error). This information is then used by `IsPackageLoaded` after `IsPackageMarkedForLoading` returned `true`, to determine the final result.
fingolfin
added
kind: enhancement
fingolfin
requested review from
ChrisJefferson,
markuspf,
olexandr-konovalov and
wilfwilson
fingolfin
added
topic: packages
ChrisJefferson
approved these changes
Sep 27, 2018
wilfwilson
approved these changes
Sep 28, 2018
Member
Author
|
Backported to stable-4.10 as c94a364 |
fingolfin
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, it now aborts immediately if the package is not loaded, and
doesn't call the package's
AvailabilityTestfunction (fixes #2862).This was achieved by not using
TestPackageAvailabilityanymore, but ratherIsPackageMarkedForLoading. The main difference to the latter now is this:We now record whether a package fully completed loading (in particular, we
record whether its
init.gandread.gexecuted without an error). Thisinformation is then used by
IsPackageLoadedafterIsPackageMarkedForLoadingreturnedtrue, to determine the final result.I would suggest backporting this to GAP 4.10.