Change IsPackageLoaded to not run the inforec.AvailabilityTest function
#2862
Labels
kind: enhancement
Label for issues suggesting enhancements; and for pull requests implementing enhancements
Comments
fingolfin
added
the
kind: enhancement
fingolfin
added a commit
to fingolfin/gap
that referenced
this issue
Sep 27, 2018
First off, it now aborts immediately if the package is not loaded, and doesn't call the package's `AvailabilityTest` function (fixes gap-system#2862). This was achieved by not using `TestPackageAvailability` anymore, but rather `IsPackageMarkedForLoading`. The main difference to the latter now is this: We now record whether a package fully completed loading (in particular, we record whether its `init.g` and `read.g` executed without an error). This information is then used by `IsPackageLoaded` after `IsPackageMarkedForLoading` returned `true`, to determine the final result.
fingolfin
added a commit
that referenced
this issue
Sep 28, 2018
First off, it now aborts immediately if the package is not loaded, and doesn't call the package's `AvailabilityTest` function (fixes #2862). This was achieved by not using `TestPackageAvailability` anymore, but rather `IsPackageMarkedForLoading`. The main difference to the latter now is this: We now record whether a package fully completed loading (in particular, we record whether its `init.g` and `read.g` executed without an error). This information is then used by `IsPackageLoaded` after `IsPackageMarkedForLoading` returned `true`, to determine the final result.
fingolfin
added a commit
that referenced
this issue
Sep 28, 2018
First off, it now aborts immediately if the package is not loaded, and doesn't call the package's `AvailabilityTest` function (fixes #2862). This was achieved by not using `TestPackageAvailability` anymore, but rather `IsPackageMarkedForLoading`. The main difference to the latter now is this: We now record whether a package fully completed loading (in particular, we record whether its `init.g` and `read.g` executed without an error). This information is then used by `IsPackageLoaded` after `IsPackageMarkedForLoading` returned `true`, to determine the final result.
ssiccha
pushed a commit
to ssiccha/gap
that referenced
this issue
Mar 27, 2019
First off, it now aborts immediately if the package is not loaded, and doesn't call the package's `AvailabilityTest` function (fixes gap-system#2862). This was achieved by not using `TestPackageAvailability` anymore, but rather `IsPackageMarkedForLoading`. The main difference to the latter now is this: We now record whether a package fully completed loading (in particular, we record whether its `init.g` and `read.g` executed without an error). This information is then used by `IsPackageLoaded` after `IsPackageMarkedForLoading` returned `true`, to determine the final result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now, you get this if e.g. semigroups is not loaded:
That Info message is printed by semigroups
inforec.AvailabilityTestfunction, and is undesirable here; it also is simply not necessary to call this function if the package has been determined to not be loaded at all.This goes away if
AvailabilityTestis not called.The text was updated successfully, but these errors were encountered: