Fix RepresentativeAction for symmetric and alternating groups (for master branch) #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
changed the title
Specifically, do not rely on MappingPermListList not moving additional points. Fixes gap-system#1431
fingolfin
force-pushed
the
mh/fix-MappingPermLstList
branch
from
1f55acc
to
cd82bf3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1537 +/- ##
==========================================
+ Coverage 64.17% 64.17% +<.01%
==========================================
Files 990 990
Lines 321773 321777 +4
Branches 13063 13063
==========================================
+ Hits 206503 206510 +7
+ Misses 112453 112448 -5
- Partials 2817 2819 +2
|
|
This was made superflous by merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, do not rely on MappingPermListList not moving additional
points. Fixes #1431
This PR supersedes PR #1438. It is based on PR #1453; but I turned it into a truly minimal patch, and also added a test case.