Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RepresentativeAction fails on Symmetric and Alternating Groups #1431

Closed
ChrisJefferson opened this issue Jun 19, 2017 · 2 comments
Closed

RepresentativeAction fails on Symmetric and Alternating Groups #1431

ChrisJefferson opened this issue Jun 19, 2017 · 2 comments
Labels
kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them
Milestone
GAP 4.8.8

Comments

@ChrisJefferson
Copy link
Contributor

RepresentativeAction produces incorrect answers for both symmetric and alternating groups, with both OnTuples and OnSets, by producing elements outside the group. This bug was found by Mun See Chang

For example:

gap> RepresentativeAction(SymmetricGroup([5,7,11,15]),[7,11],[5,15],OnTuples);
(5,6,7)(11,15,14,13,12)
@ChrisJefferson
Copy link
Contributor Author

Fixed in master in #1432, will need a seperate patch for 4.8.

stevelinton added a commit to stevelinton/gap that referenced this issue Jun 26, 2017
@stevelinton
Minimal fix for issue gap-system#1431 for stable. Do not rely on Mapp…
1c68640 
…ingPermListList not moving additional points.
@stevelinton
Copy link
Contributor

PR #1453 should address this in stable-4.8.

@stevelinton stevelinton mentioned this issue Jun 26, 2017
Closed
@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them labels Jul 3, 2017
fingolfin added a commit to fingolfin/gap that referenced this issue Jul 26, 2017
@fingolfin
Fix RepresentativeAction for symmetric and alternating groups
1f55acc 
Specifically, do not rely on MappingPermListList not moving additional
points. Fixes gap-system#1431
fingolfin added a commit to fingolfin/gap that referenced this issue Jul 26, 2017
@fingolfin
Fix RepresentativeAction for symmetric and alternating groups
fc16d19 
Specifically, do not rely on MappingPermListList not moving additional
points. Fixes gap-system#1431
This was referenced Jul 26, 2017
Merged
Closed
fingolfin added a commit to fingolfin/gap that referenced this issue Jul 26, 2017
@fingolfin
Fix RepresentativeAction for symmetric and alternating groups
86c7bea 
Specifically, do not rely on MappingPermListList not moving additional
points. Fixes gap-system#1431
fingolfin added a commit to fingolfin/gap that referenced this issue Jul 26, 2017
@fingolfin
Fix RepresentativeAction for symmetric and alternating groups
cd82bf3 
Specifically, do not rely on MappingPermListList not moving additional
points. Fixes gap-system#1431
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.8.8 milestone Jul 31, 2017
@olexandr-konovalov olexandr-konovalov mentioned this issue Jul 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them
Projects
None yet
Milestone
GAP 4.8.8
Development

No branches or pull requests
4 participants
@fingolfin @ChrisJefferson @olexandr-konovalov @stevelinton