Skip to content

Commit

Permalink
FIX: Only store induced FF setup as own, if it is
Browse files Browse the repository at this point in the history
I.e. do not store an FF setup if the factor has a radical -- code often
assume that the given radical factor is indeed fitting free.
Subsequent manual changes
  • Loading branch information
hulpke authored and fingolfin committed Jun 13, 2019
1 parent 4f6aa5c commit fe8ebae
Showing 1 changed file with 11 additions and 9 deletions.
20 changes: 11 additions & 9 deletions lib/fitfree.gi
Original file line number Diff line number Diff line change
Expand Up @@ -166,15 +166,17 @@ local ffs,hom,U,rest,ker,r,p,l,i,depths;

U!.cachedFFS:=[[ffs,r]];

# FittingFreeLiftSetup for U
r:=rec(inducedfrom:=ffs,
pcgs:=ipcgs,
depths:=depths,
pcisom:=ffs.pcisom,
radical:=ker,
factorhom:=rest
);
SetFittingFreeLiftSetup(U,r);
# FittingFreeLiftSetup for U, if correct
if Size(RadicalGroup(Image(rest,U)))=1 then
r:=rec(inducedfrom:=ffs,
pcgs:=ipcgs,
depths:=depths,
pcisom:=ffs.pcisom,
radical:=ker,
factorhom:=rest
);
SetFittingFreeLiftSetup(U,r);
fi;

return U;

Expand Down

0 comments on commit fe8ebae

Please sign in to comment.