Skip to content

Commit

Permalink
FIX: Fitting free data use in clashom
Browse files Browse the repository at this point in the history
If the group has been obtained as subgroup from a fitting free computation,
the data will be inherited and might not guarantee that the factor group
really is fitting free. Test/resolve this.

This fixes #3139
  • Loading branch information
hulpke authored and fingolfin committed Jun 13, 2019
1 parent 55fba34 commit 4f6aa5c
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
9 changes: 8 additions & 1 deletion lib/clashom.gi
Original file line number Diff line number Diff line change
Expand Up @@ -2391,8 +2391,15 @@ local r, #radical
hom:=ser.factorhom;
ntrihom:=true;
f:=Image(hom);
# if lift setup is inherited, f might not be trivial-fitting
if Size(RadicalGroup(f))>1 then
# this is proper recursion
cl:=ConjugacyClasses(f:onlysizes:=false);
cl:=List(cl,x->[Representative(x),Centralizer(x)]);
else
# we need centralizers
cl:=ConjugacyClassesFittingFreeGroup(f:onlysizes:=false);
cl:=ConjugacyClassesFittingFreeGroup(f:onlysizes:=false);
fi;
fants:=Filtered(NormalSubgroups(f),x->Size(x)>1 and Size(x)<Size(f));
else
if IsPermGroup(G) then
Expand Down
5 changes: 5 additions & 0 deletions tst/testbugfix/2018-12-30-clashom.tst
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Bug #3139
gap> wreathy := WreathProduct(SymmetricGroup(2),SymmetricGroup(5));;
gap> classes := ConjugacyClasses(wreathy);;
gap> badsubgroup := StabilizerOfExternalSet( classes[2] );;
gap> ConjugacyClasses( badsubgroup );;

0 comments on commit 4f6aa5c

Please sign in to comment.