Some fixes for OutputCoverallsJsonCoverage #64
Conversation
…rallsJson * Check whether a file that occurs in the profiling data exists before outputting coverage (and trying to run md5sum on it) * Catch the case where pathtoremove is empty, because GAP's ReplacedString does not terminate in that case
| @@ -760,6 +761,14 @@ function(data, outfile, jobid, pathtoremove) | |||
| return SplitString(str, " ")[1]; | |||
| end; | |||
|
|
|||
| # GAP's ReplacedString does not terminate for | |||
| # empty string to replace | |||
There was a problem hiding this comment.
Probably should be a bug report for GAP, too? (perhaps you already made one, I did not check)
There was a problem hiding this comment.
I have indeed: gap-system/gap#3134
| @@ -783,13 +792,13 @@ function(data, outfile, jobid, pathtoremove) | |||
| prev := false; | |||
|
|
|||
| for file in data.line_info do | |||
| if file[1] <> "stream" then | |||
| if IsExistingFile(file[1]) then | |||
There was a problem hiding this comment.
Could the same fix please be applied to the codecov generator function a few lines above this one?
There was a problem hiding this comment.
Sure, though strictly speaking this is not necessary for codecov output (as we don't care whether the file currently exists).
I wonder whether we can compute the md5sum for a file and put that into the profiling output?
|
Just checking, is this ready to be merged? |
|
Yeah, though I will make another PR that will add some more stuff (giving the ci service name, and outputting the option |
outputting coverage (and trying to run md5sum on it)
does not terminate in that case