Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReplacedString does not terminate when argument old is the empty string #3134

Closed
markuspf opened this issue Dec 21, 2018 · 0 comments · Fixed by #5523
Closed

ReplacedString does not terminate when argument old is the empty string #3134

markuspf opened this issue Dec 21, 2018 · 0 comments · Fixed by #5523
Labels
good first issue Issues that can be understood and addressed by newcomers to GAP development kind: bug Issues describing general bugs, and PRs fixing them topic: documentation Issues and PRs related to documentation
Milestone
GAP 4.13.0

Comments

@markuspf
Copy link
Member 

gap> ReplacedString("","","");

does not terminate. Also the documentation is incomplete, as it does not document the fourth argument:

gap> ReplacedString("","","bla", true);
"bla"
@markuspf markuspf mentioned this issue Dec 21, 2018
Merged
@markuspf markuspf added kind: bug Issues describing general bugs, and PRs fixing them topic: documentation Issues and PRs related to documentation labels Jan 10, 2019
@fingolfin fingolfin added the good first issue Issues that can be understood and addressed by newcomers to GAP development label Mar 21, 2019
@fingolfin fingolfin added this to the GAP 4.13.0 milestone Dec 23, 2022
@fingolfin fingolfin mentioned this issue Oct 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that can be understood and addressed by newcomers to GAP development kind: bug Issues describing general bugs, and PRs fixing them topic: documentation Issues and PRs related to documentation
Projects
None yet
Milestone
GAP 4.13.0
Development

Successfully merging a pull request may close this issue.

Fix infinite recursion in ReplacedString when <old> string is empty fingolfin/gap
2 participants
@fingolfin @markuspf