update the Julia code for downloading files #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- avoid the call `JuliaImportPackage("Downloads")`,
which somehow does not work as expected in certain situations,
see oscar-system/GAP.jl/issues/1040
- update the code of the function such that it contains the changes from
oscar-system/GAP.jl/pull/961
(Yes, the new code looks ugly, and the next GAP.jl version will contain
support for the "call with catch *and* keyword arguments" situation.)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #134 +/- ##
=======================================
Coverage 86.42% 86.42%
=======================================
Files 22 22
Lines 1009 1009
=======================================
Hits 872 872
Misses 137 137 |
ThomasBreuer
added a commit
to ThomasBreuer/GAP.jl
that referenced
this pull request
Sep 18, 2024
(motivated mainly by gap-packages/PackageManager/pull/134 and the issues mentioned there) - support keyword arguments in `CallJuliaFunctionWithCatch` - do not use the deprecated and undocumented `Core._apply` - update the initializations in `init_packagemanager`: Replacing `PKGMAN_DownloadURL` is no longer needed, replacing `PKGMAN_RemoveDir` was in a wrong place. - start better documentation of Julia syntax features
fingolfin
approved these changes
Sep 19, 2024
|
@mtorpey do you think we can make another PackageManger release soonish, so we have this change in a released version (and it can become part of GAP 4.13.2) ? |
|
Yes! I'll make one today. |
|
Thanks @mtorpey! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid the call
JuliaImportPackage("Downloads"), which somehow does not work as expected in certain situations, see Warning "The Julia package 'Downloads' cannot be loaded" when starting GAP.jl in CI oscar-system/GAP.jl#1040update the code of the function such that it contains the changes from use a custom
Downloads.Downloaderfor installing GAP packages oscar-system/GAP.jl#961(Yes, the new code looks ugly, and the next GAP.jl version will contain support for the "call with catch and keyword arguments" situation.)