Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning "The Julia package 'Downloads' cannot be loaded" when starting GAP.jl in CI #1040

Closed
fingolfin opened this issue Sep 16, 2024 · 3 comments · Fixed by #1054
Closed

Comments

@fingolfin
Copy link
Member

This is printed by JuliaImportPackage.

That in turn is called by GAP's PackageManage which has a Download.g file containing this:

if IsBound(Julia) and JuliaImportPackage("Downloads") = true then
@fingolfin
Copy link
Member Author

Perhaps turning up the PackageLoadingMessage to PACKAGE_DEBUG will give some insight.

Also perhaps we should take advantage of that code in PackageManager to remove the hack where we patch PackageManager in src/packages.jl, function init_packagemanager.

@ThomasBreuer
Copy link
Member

ThomasBreuer commented Sep 16, 2024

Thanks for the hint about the JuliaImportPackage call in a GAP package.
This explains why a git grep JuliaImportPackage in GAP.jl did not answer the question who calls this function with "Downloads".

I think that this problem will disappear when we simply omit the JuliaImportPackage call from the function in PackageManager, and change its code such that it calls Julia.GAP.Packages.Downloads.downloads instead of Julia.Downloads.downloads.
And I think that this function must be changed anyhow because it does not contain the change from /pull/961.

(Still it would be interesting why the warning appears only in certain CI runs.)

ThomasBreuer added a commit to ThomasBreuer/PackageManager that referenced this issue Sep 18, 2024
- avoid the call `JuliaImportPackage("Downloads")`,
  which somehow does not work as expected in certain situations,
  see oscar-system/GAP.jl/issues/1040

- update the code of the function such that it contains the changes from
  oscar-system/GAP.jl/pull/961

  (Yes, the new code looks ugly, and the next GAP.jl version will contain
  support for the "call with catch *and* keyword arguments" situation.)
fingolfin pushed a commit to gap-packages/PackageManager that referenced this issue Sep 19, 2024
- avoid the call `JuliaImportPackage("Downloads")`,
  which somehow does not work as expected in certain situations,
  see oscar-system/GAP.jl/issues/1040

- update the code of the function such that it contains the changes from
  oscar-system/GAP.jl/pull/961

  (Yes, the new code looks ugly, and the next GAP.jl version will contain
  support for the "call with catch *and* keyword arguments" situation.)
@thofma
Copy link
Contributor

thofma commented Sep 19, 2024

I also saw this locally:

Precompiling project...
  11 dependencies successfully precompiled in 76 seconds. 77 already precompiled. 1 skipped during auto due to previous errors.
  1 dependency had output during precompilation:
┌ Hecke → GAPExt
│  #I  The Julia package 'Downloads' cannot be loaded.
└

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants