Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt use of ERROR_OUTPUT #85

Merged
merged 1 commit into from
Nov 28, 2018
Merged

Adapt use of ERROR_OUTPUT #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Adapt use of ERROR_OUTPUT 
ERROR_OUTPUT was made a read-only global variable. But we
still want to change it.
  • Loading branch information
@ssiccha
ssiccha committed Nov 27, 2018
commit 7c51328eed4f6099f12caf6cb9e499909a63df82
3 changes: 3 additions & 0 deletions gap/JupyterKernel.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,10 @@ function(conf)
# TODO: This is of course still hacky, but better than before
kernel!.StdOut := OutputStreamZmq(kernel, kernel!.IOPub);
kernel!.StdErr := OutputStreamZmq(kernel, kernel!.IOPub, "stderr");
# TODO: Hack to be able to change ERROR_OUTPUT.
MakeReadWriteGlobal("ERROR_OUTPUT");
ERROR_OUTPUT := kernel!.StdErr;
MakeReadOnlyGlobal("ERROR_OUTPUT");
OutputLogTo(kernel!.StdOut);

# Jupyter Heartbeat and Control channel is handled by a fork'ed GAP process
Expand Down