Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt use of ERROR_OUTPUT #85

Merged
merged 1 commit into from
Nov 28, 2018

Conversation

ssiccha
Copy link
Contributor

@ssiccha ssiccha commented Nov 27, 2018

ERROR_OUTPUT was made a read-only global variable. But we
still want to change it.

ERROR_OUTPUT was made a read-only global variable. But we
still want to change it.
@codecov
Copy link

codecov bot commented Nov 27, 2018

Codecov Report

Merging #85 into master will decrease coverage by 0.16%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   72.13%   71.97%   -0.17%     
==========================================
  Files          14       14              
  Lines         865      860       -5     
==========================================
- Hits          624      619       -5     
  Misses        241      241
Impacted Files Coverage Δ
gap/JupyterKernel.gi 80.53% <100%> (+0.14%) ⬆️
gap/JupyterStream.gi 70% <0%> (-0.43%) ⬇️
gap/JupyterHelp.gi 48.1% <0%> (-0.28%) ⬇️
gap/JupyterInspection.gi 87.32% <0%> (-0.18%) ⬇️
gap/JupyterStream.gd 100% <0%> (ø) ⬆️
gap/JupyterUtil.gd 100% <0%> (ø) ⬆️
gap/JupyterHelp.gd 100% <0%> (ø) ⬆️
gap/JupyterRenderable.gd 100% <0%> (ø) ⬆️

@embray
Copy link

embray commented Nov 28, 2018

Looks good, thanks.

@markuspf markuspf merged commit 587a123 into gap-packages:master Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants