Skip to content

Conversation

@mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Mar 27, 2025

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

@mvdbeek mvdbeek marked this pull request as draft March 28, 2025 07:34
@mvdbeek
Copy link
Member Author

mvdbeek commented Mar 28, 2025

None of the bwa-mem2 tests ran, that's certainly interesting!

@mvdbeek mvdbeek marked this pull request as ready for review March 28, 2025 07:55
@mvdbeek
Copy link
Member Author

mvdbeek commented Mar 28, 2025

That's because of the TestsCaseValidation exception. The good news is that claude code was able to fix this without manual work, just tell it to use planemo lint.

@bernt-matthias
Copy link
Contributor

That's because of the TestsCaseValidation exception. The good news is that claude code was able to fix this without manual work, just tell it to use planemo lint.

Wasn't aware that this becomes active with profile 24.2, good to know.

I somehow have the feeling, that planemo should tell us about this. Maybe by parsing the number of tests and checking if the correct number of tests was executed.

@mvdbeek mvdbeek merged commit 9b90dfa into galaxyproject:main Mar 28, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants