Fix: serialize tool_shed_urls directly from the API
#16561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davelopez
force-pushed
the
fix_install_tools_from_admin_panel
branch
from
34fc5f3
to
e0c102c
Compare
jdavcs
reviewed
Aug 16, 2023
|
Although test failures are relevant. |
Do you know which one? It is hard to tell with |
|
I bet that's tox-dev/tox#3089, which ended up in 4.9.0 released yesterday. I don't know if this is a bug or not though. |
17 tasks
davelopez
force-pushed
the
fix_install_tools_from_admin_panel
branch
from
6bdbf7c
to
f14fd25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16544
The
tool_shed_urlsare now serialized as part of theapi/configurationresponse for Admins instead of injected later through the client controller.How to test the changes?
License